feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Be a bit more explicit about why debugging fails

Browse Source 
Ignoring python, pure Qml debugging is fine without debugger in the kit,
everything else not.

Fixes: QTCREATORBUG-26152
Change-Id: If6ebb50968ede85e8210e191dbabd51cf61e177b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2021-08-20 12:36:41 +02:00
parent 2adaea866f
commit 6d3659bef4
1 changed files with 29 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/plugins/debugger/debuggerruncontrol.cpp
View File

@@ -95,6 +95,16 @@ DebuggerEngine *createQmlEngine();
DebuggerEngine *createLldbEngine();
DebuggerEngine *createUvscEngine();
static QString noEngineMessage()
{
return DebuggerPlugin::tr("Unable to create a debugging engine.");
}
static QString noDebuggerInKitMessage()
{
return DebuggerPlugin::tr("The kit does not have a debugger set.");
}
class CoreUnpacker final : public RunWorker
{
public:
@@ -526,8 +536,8 @@ void DebuggerRunTool::start()
break;
default:
if (!m_runParameters.isQmlDebugging) {
reportFailure(DebuggerPlugin::tr("Unable to create a debugging engine. "
"Please select a Debugger Setting from the Run page of the project mode."));
reportFailure(noEngineMessage() + '\n' +
DebuggerPlugin::tr("Please select a Debugger Setting from the Run page of the project mode."));
return;
}
// Can happen for pure Qml.
@@ -545,7 +555,10 @@ void DebuggerRunTool::start()
}
if (!m_engine) {
reportFailure(DebuggerPlugin::tr("Unable to create a debugging engine."));
QString msg = noEngineMessage();
if (!DebuggerKitAspect::debugger(runControl()->kit()))
msg += '\n' + noDebuggerInKitMessage();
reportFailure(msg);
return;
}
@@ -739,7 +752,7 @@ bool DebuggerRunTool::fixupParameters()
rp.debugger.environment.set(var, rp.inferior.environment.expandedValueForKey(var));
// validate debugger if C++ debugging is enabled
if (rp.isCppDebugging() && !rp.validationErrors.isEmpty()) {
if (!rp.validationErrors.isEmpty()) {
reportFailure(rp.validationErrors.join('\n'));
return false;
}
@@ -884,6 +897,18 @@ DebuggerRunTool::DebuggerRunTool(RunControl *runControl, AllowTerminal allowTerm
m_runParameters.isQmlDebugging = aspect->useQmlDebugger();
m_runParameters.multiProcess = aspect->useMultiProcess();
m_runParameters.additionalStartupCommands = aspect->overrideStartup();
if (aspect->useCppDebugger()) {
if (DebuggerKitAspect::debugger(kit)) {
const Tasks tasks = DebuggerKitAspect::validateDebugger(kit);
for (const Task &t : tasks) {
if (t.type != Task::Warning)
m_runParameters.validationErrors.append(t.description());
}
} else {
m_runParameters.validationErrors.append(noDebuggerInKitMessage());
}
}
}
m_runParameters.inferior = runnable();
@@ -908,13 +933,6 @@ DebuggerRunTool::DebuggerRunTool(RunControl *runControl, AllowTerminal allowTerm
if (ok)
m_runParameters.nativeMixedEnabled = bool(nativeMixedOverride);
// This will only be shown in some cases, but we don't want to access
// the kit at that time anymore.
const Tasks tasks = DebuggerKitAspect::validateDebugger(kit);
for (const Task &t : tasks) {
if (t.type != Task::Warning)
m_runParameters.validationErrors.append(t.description());
}
RunConfiguration *runConfig = runControl->runConfiguration();
if (runConfig && runConfig->property("supportsDebugger").toBool()) {