feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix warning about signed/unsigned comparison

Browse Source 
Use int instead of unsigned and do some code cosmetics while at it.
This commit is contained in:
Tobias Hunger
2011-04-08 11:14:11 +02:00
parent 9043b8e73a
commit 6db7426d5e
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/libs/utils/submiteditorwidget.cpp
View File

@@ -518,7 +518,7 @@ void SubmitEditorWidget::updateDiffAction()
void SubmitEditorWidget::updateCheckAllComboBox() void SubmitEditorWidget::updateCheckAllComboBox()
{ {
m_d->m_ignoreChange = true; m_d->m_ignoreChange = true;
unsigned checkedCount = checkedFilesCount(); int checkedCount = checkedFilesCount();
if (checkedCount == 0) if (checkedCount == 0)
m_d->m_ui.checkAllCheckBox->setCheckState(Qt::Unchecked); m_d->m_ui.checkAllCheckBox->setCheckState(Qt::Unchecked);
else if (checkedCount == m_d->m_ui.fileView->model()->rowCount()) else if (checkedCount == m_d->m_ui.fileView->model()->rowCount())
@@ -536,14 +536,14 @@ bool SubmitEditorWidget::hasSelection() const
return false; return false;
} }
unsigned SubmitEditorWidget::checkedFilesCount() const int SubmitEditorWidget::checkedFilesCount() const
{ {
unsigned checkedCount = 0; int checkedCount = 0;
if (const QAbstractItemModel *model = m_d->m_ui.fileView->model()) { if (const QAbstractItemModel *model = m_d->m_ui.fileView->model()) {
const int count = model->rowCount(); const int count = model->rowCount();
for (int i = 0; i < count; i++) for (int i = 0; i < count; ++i)
if (listModelChecked(model, i, checkableColumn)) if (listModelChecked(model, i, checkableColumn))
checkedCount++; ++checkedCount;
} }
return checkedCount; return checkedCount;
} }

2
src/libs/utils/submiteditorwidget.h
View File

@@ -145,7 +145,7 @@ private slots:
private: private:
bool hasSelection() const; bool hasSelection() const;
unsigned checkedFilesCount() const; int checkedFilesCount() const;
SubmitEditorWidgetPrivate *m_d; SubmitEditorWidgetPrivate *m_d;
}; };