feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Add QTC_ASSERTS

Browse Source 
This can prevent crashes, but is unexpected behaivour.

Change-Id: Ie0944652c230a25e18f5d740cf134bc3ef7e2f2f
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Thomas Hartmann
2023-12-21 15:27:40 +01:00
parent 009b664b7b
commit 6fcb853b19
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/qmldesigner/designercore/model/texttomodelmerger.cpp
View File

@@ -388,6 +388,7 @@ bool smartVeryFuzzyCompare(const QVariant &value1, const QVariant &value2)
void removeModelNode(const QmlDesigner::ModelNode &modelNode) void removeModelNode(const QmlDesigner::ModelNode &modelNode)
{ {
QTC_ASSERT(modelNode.isValid(), return );
modelNode.model()->removeModelNodes({modelNode}, modelNode.model()->removeModelNodes({modelNode},
QmlDesigner::BypassModelResourceManagement::Yes); QmlDesigner::BypassModelResourceManagement::Yes);
} }
@@ -400,6 +401,7 @@ bool smartColorCompare(const QVariant &value1, const QVariant &value2)
void removeProperty(const QmlDesigner::AbstractProperty &modelProperty) void removeProperty(const QmlDesigner::AbstractProperty &modelProperty)
{ {
QTC_ASSERT(modelProperty.isValid(), return );
modelProperty.model()->removeProperties({modelProperty}, modelProperty.model()->removeProperties({modelProperty},
QmlDesigner::BypassModelResourceManagement::Yes); QmlDesigner::BypassModelResourceManagement::Yes);
} }