feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Android: Remove unreachable return

Browse Source 
Reported by Coverity.

Change-Id: Id1b67f0adae3ff0c9157428726778c8c3b2a03a7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Orgad Shaneh
2023-03-06 09:10:34 +02:00
committed by Orgad Shaneh
parent 476c072b00
commit 70369aca13
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/plugins/android/androidmanager.cpp
View File

@@ -278,18 +278,15 @@ QString packageSubPath(PackageFormat format, BuildConfiguration::BuildType build
const bool deb = (buildType == BuildConfiguration::Debug); const bool deb = (buildType == BuildConfiguration::Debug);
if (format == Apk) { if (format == Apk) {
if (deb) if (deb) {
return sig ? packageSubPath(Apk, BuildConfiguration::Release, true) // Intentional return sig ? packageSubPath(Apk, BuildConfiguration::Release, true) // Intentional
: QLatin1String("apk/debug/android-build-debug.apk"); : QLatin1String("apk/debug/android-build-debug.apk");
else }
return QLatin1String(sig ? "apk/release/android-build-release-signed.apk" return QLatin1String(sig ? "apk/release/android-build-release-signed.apk"
: "apk/release/android-build-release-unsigned.apk"); : "apk/release/android-build-release-unsigned.apk");
} else {
return QLatin1String(deb ? "bundle/debug/android-build-debug.aab"
: "bundle/release/android-build-release.aab");
} }
return QLatin1String(deb ? "bundle/debug/android-build-debug.aab"
return {}; : "bundle/release/android-build-release.aab");
} }
FilePath AndroidManager::packagePath(const Target *target) FilePath AndroidManager::packagePath(const Target *target)