feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Replace foreach with ranged for loop

Browse Source 
Change-Id: I6238651d0b6ea8b932195711d3da7442158d2456
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-10-06 20:00:31 +02:00
parent 28c507eccb
commit 70466ed811
4 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/fossil/commiteditor.cpp
View File

@@ -80,7 +80,7 @@ void CommitEditor::setFields(const QString &repositoryRoot, const BranchInfo &br
[](const VcsBase::VcsBaseClient::StatusItem &item) [](const VcsBase::VcsBaseClient::StatusItem &item)
{ return item.flags != Constants::FSTATUS_UNKNOWN; }); { return item.flags != Constants::FSTATUS_UNKNOWN; });
for (const VcsBase::VcsBaseClient::StatusItem &item : toAdd) for (const VcsBase::VcsBaseClient::StatusItem &item : toAdd)
m_fileModel->addFile(item.file, item.flags); m_fileModel->addFile(item.file, item.flags);
setFileModel(m_fileModel); setFileModel(m_fileModel);
} }

3
plugins/fossil/fossilclient.cpp
View File

@@ -198,7 +198,8 @@ public:
QStringList args; QStringList args;
// split "-t val" => "-t" "val" // split "-t val" => "-t" "val"
foreach (const QString &arg, VcsBaseEditorConfig::arguments()) { const QStringList arguments = VcsBaseEditorConfig::arguments();
for (const QString &arg : arguments) {
if (arg.startsWith("-t")) { if (arg.startsWith("-t")) {
args << arg.split(' '); args << arg.split(' ');

5
plugins/fossil/fossilplugin.cpp
View File

@@ -853,7 +853,8 @@ bool FossilPluginPrivate::submitEditorAboutToClose()
extraOptions << "--branch" << enquotedBranch; extraOptions << "--branch" << enquotedBranch;
} }
// Tags // Tags
foreach (QString tag, commitWidget->tags()) { const QStringList tags = commitWidget->tags();
for (const QString &tag : tags) {
extraOptions << "--tag" << tag; extraOptions << "--tag" << tag;
} }
@@ -886,7 +887,7 @@ void FossilPluginPrivate::updateActions(VcsBase::VcsBasePluginPrivate::ActionSta
m_revertFile->setParameter(filename); m_revertFile->setParameter(filename);
m_statusFile->setParameter(filename); m_statusFile->setParameter(filename);
foreach (QAction *repoAction, m_repositoryActionList) for (QAction *repoAction : qAsConst(m_repositoryActionList))
repoAction->setEnabled(repoEnabled); repoAction->setEnabled(repoEnabled);
} }

8
plugins/fossil/wizard/fossiljsextension.cpp
View File

@@ -56,10 +56,10 @@ void FossilJsExtension::parseArgOptions(const QStringList &args, QMap<QString, Q
{ {
options.clear(); options.clear();
foreach (const QString &arg, args) { for (const QString &arg : args) {
if (arg.isEmpty()) continue; if (arg.isEmpty())
continue;
QStringList opt = arg.split('|', Qt::KeepEmptyParts); const QStringList opt = arg.split('|', Qt::KeepEmptyParts);
options.insert(opt[0], opt.size() > 1 ? opt[1] : QString()); options.insert(opt[0], opt.size() > 1 ? opt[1] : QString());
} }
} }