feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Some code cosmetics

Browse Source 
Silence a warning about using a pair by value instead by reference.

Also, remove an unnecessary duplicated check.

Change-Id: Idd5a01cdfcb16dad03389d2f360e0b2dbff21dc8
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
hjk
2017-03-13 10:18:41 +01:00
parent 9f2822a687
commit 70578004cb
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/projectexplorer/session.cpp
View File

@@ -200,8 +200,6 @@ void SessionManager::updateProjectTree(Project *pro)
break; break;
} }
} }
if (!currentPair)
return;
if (!currentPair) if (!currentPair)
return; // Project was already de-registered and is shutting down return; // Project was already de-registered and is shutting down
@@ -675,7 +673,7 @@ Project *SessionManager::projectForNode(Node *node)
while (rootProjectNode && rootProjectNode->parentFolderNode() != &d->m_sessionNode) while (rootProjectNode && rootProjectNode->parentFolderNode() != &d->m_sessionNode)
rootProjectNode = rootProjectNode->parentFolderNode(); rootProjectNode = rootProjectNode->parentFolderNode();
for (const QPair<Project *,ProjectNode*> pair : d->m_projects) { for (const QPair<Project *, ProjectNode *> &pair : d->m_projects) {
if (pair.second == rootProjectNode) if (pair.second == rootProjectNode)
return pair.first; return pair.first;
} }