COIN: Add test instructions

For now just run them without failing the precheck on failing tests.
The test results are only visible in the precheck details
on testresults.qt.io

Remove the fixed timeout of 5 seconds, since this depends on the test
setup where the tests are run, and it is not possible to override a
fixed timeout with the --timeout option of ctest.

Change-Id: Ib5f12092b64d0cf87e1213b031e1990973e18669
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>

cmake/QtCreatorAPIInternal.cmake

@@ -257,15 +257,15 @@ endfunction()
 function(finalize_test_setup test_name)
   cmake_parse_arguments(_arg "" "TIMEOUT" "" ${ARGN})
   if (DEFINED _arg_TIMEOUT)
-    set(timeout ${_arg_TIMEOUT})
+    set(timeout_arg TIMEOUT ${_arg_TIMEOUT})
   else()
-    set(timeout 5)
+    set(timeout_arg)
   endif()
   # Never translate tests:
   set_tests_properties(${name}
     PROPERTIES
       QT_SKIP_TRANSLATION ON
-      TIMEOUT ${timeout}
+      ${timeout_arg}
   )
 
   if (WIN32)

coin/instructions/build.yaml

@@ -148,7 +148,7 @@ instructions:
       equals_value: Windows
 
   - type: UploadArtifact
-    archiveDirectory: "{{.AgentWorkingDir}}/qt-creator/qt-creator_build/install/"
+    archiveDirectory: "{{.AgentWorkingDir}}"
     transferType: UploadModuleBuildArtifact
     maxTimeInSeconds: 1800
     maxTimeBetweenOutput: 1800

coin/instructions/test.yaml

@@ -0,0 +1,10 @@
+type: Group
+instructions:
+  - type: ChangeDirectory
+    directory: "{{.AgentWorkingDir}}/qt-creator/qt-creator_build/build"
+  - type: ExecuteCommand
+    command: "ctest -j 4 --timeout 60 --output-on-failure"
+    maxTimeInSeconds: 600
+    maxTimeBetweenOutput: 600
+    userMessageOnFailure: "Failed to run tests, check logs"
+    ignoreExitCode: true

coin/module_config.yaml

@@ -63,13 +63,18 @@ make_instructions: &make_instructions
     - !include "{{qt-creator/qt-creator}}/provision.yaml"
     - !include "{{qt-creator/qt-creator}}/build.yaml"
 
+test_instructions: &test_instructions
+  type: Group
+  instructions:
+    - !include "{{qt-creator/qt-creator}}/test.yaml"
 
 instructions:
   Build:
     - *common_environment
     - *make_instructions
 
-  Test: []
+  Test:
+    - *test_instructions
 
   LicenseCheck:
     - *run_license_check

coin/product_dependencies.yaml

@@ -1,4 +1,4 @@
 dependencies:
-  ../../qt/qt5.git:
-    ref: "6.2"
+  ../../qt/tqtc-qt5.git:
+    ref: "tqtc/lts-6.2"