feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Don't print out warnings when wizard.json parsing fails

Browse Source 
If plugins are disabled (e.g. Designer), some form page types (e.g.
"Form") might be missing. Therefore the parsing of some wizard.json
files will fail, which is expected.

A recent patch added warning output for this case:
   Failed to create wizard:  "wizard.json"

Let's remove that, because that is the job of Qt Creator's Option:
   -customwizard-verbose

Amends: 32799b3a7b

Change-Id: Idda037c2e48ef290ff95754393572ec4309347b2
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Alessandro Portale
2021-10-15 20:48:29 +02:00
parent 4544d891aa
commit 719cdfd426
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/projectexplorer/jsonwizard/jsonwizardfactory.cpp
View File

@@ -400,14 +400,12 @@ QList<Core::IWizardFactory *> JsonWizardFactory::createWizardFactories()
.arg(currentFile.fileName())
.arg(line).arg(column)
.arg(error.errorString()));
qWarning() << "Failed to parse wizard: " << currentFile.fileName();
continue;
}
if (!json.isObject()) {
verboseLog.append(tr("* Did not find a JSON object in \"%1\".\n")
.arg(currentFile.fileName()));
qWarning() << "Failed to parse wizard: " << currentFile.fileName();
continue;
}
@@ -425,7 +423,6 @@ QList<Core::IWizardFactory *> JsonWizardFactory::createWizardFactories()
JsonWizardFactory *factory = createWizardFactory(data, currentDir, &errorMessage);
if (!factory) {
verboseLog.append(tr("* Failed to create: %1\n").arg(errorMessage));
qWarning() << "Failed to create wizard: " << currentFile.fileName();
continue;
}