feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Fix Coverity Scan defect

Browse Source 
dialog was just created and cannot be null.

CID 1506796:  Null pointer dereferences  (REVERSE_INULL)
Null-checking "dialog" suggests that it may be null,
but it has already been dereferenced on all paths leading to the check.

Change-Id: I53c116620c91b5b41b4028e367cb286e13193cf7
Reviewed-by: Tony Leinonen <tony.leinonen@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
This commit is contained in:
Thomas Hartmann
2021-09-22 13:52:23 +02:00
parent b92187334f
commit 72d932a44e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp
View File

@@ -739,7 +739,7 @@ void NavigatorTreeModel::handleItemLibraryItemDrop(const QMimeData *mimeData, in
ChooseFromPropertyListDialog *dialog = nullptr;
dialog = new ChooseFromPropertyListDialog(targetNode, testType, Core::ICore::dialogParent());
dialog->exec();
if (!dialog || dialog->result() == QDialog::Accepted)
if (dialog->result() == QDialog::Accepted)
targetNode.bindingProperty(dialog->selectedProperty()).setExpression(newModelNode.validId());
delete dialog;
break;