feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Registryaccess: Fix defined but not used warning

Browse Source 
In file included from .../src/plugins/debugger/registerpostmortemaction.cpp:6:
.../src/shared/registryaccess/registryaccess.h:26:21: warning: 'RegistryAccess::autoRegistryValueNameC' defined but not used [-Wunused-variable]
   26 | static const WCHAR *autoRegistryValueNameC = L"Auto";

I don't think using static in a header is a nice thing, inline would
work, but we have constexpr which implies inline.

Change-Id: I7b872e65a554a9a9feb39845717c5dba7ba6777c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This commit is contained in:
Björn Schäpers
2023-05-10 21:42:59 +02:00
committed by Björn Schäpers
parent c06d291b11
commit 7327a3bbc2
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/shared/registryaccess/registryaccess.h
View File

@@ -20,10 +20,11 @@ enum AccessMode {
Registry64Mode = 0x4 // Corresponds to QSettings::Registry64Format (5.7)
};
static const char *debuggerApplicationFileC = "qtcdebugger";
static const WCHAR *debuggerRegistryKeyC = L"Software\\Microsoft\\Windows NT\\CurrentVersion\\AeDebug";
static const WCHAR *debuggerRegistryValueNameC = L"Debugger";
static const WCHAR *autoRegistryValueNameC = L"Auto";
constexpr const char debuggerApplicationFileC[] = "qtcdebugger";
constexpr const WCHAR debuggerRegistryKeyC[]
= L"Software\\Microsoft\\Windows NT\\CurrentVersion\\AeDebug";
constexpr const WCHAR debuggerRegistryValueNameC[] = L"Debugger";
constexpr const WCHAR autoRegistryValueNameC[] = L"Auto";
static inline QString wCharToQString(const WCHAR *w)
{