feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Fix usage of line widget

Browse Source 
Adding the same widget to two different layouts obviously
does not work. Create two separate widgets for this.

Change-Id: I1c598d7ac45b7a13cea129a444697d64a607f243
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Stenger
2018-08-08 12:38:23 +02:00
parent 0ab5402d4c
commit 735aeb3e38
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/autotest/testrunner.cpp
View File

@@ -623,6 +623,14 @@ void TestRunner::onFinished()
/*************************************************************************************************/ /*************************************************************************************************/
static QFrame *createLine(QWidget *parent)
{
QFrame *line = new QFrame(parent);
line->setFrameShape(QFrame::HLine);
line->setFrameShadow(QFrame::Sunken);
return line;
}
RunConfigurationSelectionDialog::RunConfigurationSelectionDialog(const QString &buildTargetKey, RunConfigurationSelectionDialog::RunConfigurationSelectionDialog(const QString &buildTargetKey,
QWidget *parent) QWidget *parent)
: QDialog(parent) : QDialog(parent)
@@ -642,15 +650,11 @@ RunConfigurationSelectionDialog::RunConfigurationSelectionDialog(const QString &
m_buttonBox->setStandardButtons(QDialogButtonBox::Cancel|QDialogButtonBox::Ok); m_buttonBox->setStandardButtons(QDialogButtonBox::Cancel|QDialogButtonBox::Ok);
m_buttonBox->button(QDialogButtonBox::Ok)->setDefault(true); m_buttonBox->button(QDialogButtonBox::Ok)->setDefault(true);
auto line = new QFrame(this);
line->setFrameShape(QFrame::HLine);
line->setFrameShadow(QFrame::Sunken);
auto formLayout = new QFormLayout; auto formLayout = new QFormLayout;
formLayout->setFieldGrowthPolicy(QFormLayout::AllNonFixedFieldsGrow); formLayout->setFieldGrowthPolicy(QFormLayout::AllNonFixedFieldsGrow);
formLayout->addRow(m_details); formLayout->addRow(m_details);
formLayout->addRow(tr("Run Configuration:"), m_rcCombo); formLayout->addRow(tr("Run Configuration:"), m_rcCombo);
formLayout->addRow(line); formLayout->addRow(createLine(this));
formLayout->addRow(tr("Executable:"), m_executable); formLayout->addRow(tr("Executable:"), m_executable);
formLayout->addRow(tr("Arguments:"), m_arguments); formLayout->addRow(tr("Arguments:"), m_arguments);
formLayout->addRow(tr("Working Directory:"), m_workingDir); formLayout->addRow(tr("Working Directory:"), m_workingDir);
@@ -658,7 +662,7 @@ RunConfigurationSelectionDialog::RunConfigurationSelectionDialog(const QString &
auto vboxLayout = new QVBoxLayout(this); auto vboxLayout = new QVBoxLayout(this);
vboxLayout->addLayout(formLayout); vboxLayout->addLayout(formLayout);
vboxLayout->addStretch(); vboxLayout->addStretch();
vboxLayout->addWidget(line); vboxLayout->addWidget(createLine(this));
vboxLayout->addWidget(m_buttonBox); vboxLayout->addWidget(m_buttonBox);
connect(m_rcCombo, &QComboBox::currentTextChanged, connect(m_rcCombo, &QComboBox::currentTextChanged,