feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

languageutils: improve ComponentVersion::toString

Browse Source 
After benchmarking it on a i7 it was 20% faster in release.
(in debug even more)

Change-Id: Ibf4599813c2e3bc206ea77dea7fc972018554b09
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Tim Jenssen
2020-04-23 04:53:21 +02:00
parent 23ce744407
commit 77c3e7d2d4
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libs/languageutils/componentversion.cpp
View File

@@ -73,8 +73,12 @@ bool ComponentVersion::isValid() const
QString ComponentVersion::toString() const QString ComponentVersion::toString() const
{ {
return QString::fromLatin1("%1.%2").arg(QString::number(_major), QByteArray temp;
QString::number(_minor)); QByteArray result;
result += temp.setNum(_major);
result += '.';
result += temp.setNum(_minor);
return QString::fromLatin1(result);
} }
void ComponentVersion::addToHash(QCryptographicHash &hash) const void ComponentVersion::addToHash(QCryptographicHash &hash) const