feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TaskTree: Make GroupItem subclasses final

Browse Source 
They are not meant to be derived from.

Change-Id: I946565cffe27b4cb42915ba560c6dffcfda4ab43
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Jarek Kobus
2023-08-01 12:39:52 +02:00
parent 0bdf6f2a50
commit 78b035f266
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/libs/solutions/tasking/tasktree.h
View File

@@ -267,16 +267,15 @@ TASKING_EXPORT extern const GroupItem stopOnFinished;
TASKING_EXPORT extern const GroupItem finishAllAndDone;
TASKING_EXPORT extern const GroupItem finishAllAndError;
class TASKING_EXPORT Storage : public GroupItem
class TASKING_EXPORT Storage final : public GroupItem
{
public:
Storage(const TreeStorageBase &storage) : GroupItem(storage) { }
};
// Synchronous invocation. Similarly to Group - isn't counted as a task inside taskCount()
class TASKING_EXPORT Sync : public Group
class TASKING_EXPORT Sync final : public Group
{
public:
template<typename Function>
Sync(Function &&function) : Group(init(std::forward<Function>(function))) {}
@@ -314,7 +313,7 @@ private:
};
template <typename Adapter>
class CustomTask : public GroupItem
class CustomTask final : public GroupItem
{
public:
using Task = typename Adapter::Type;