feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ADS: Fix crash in auto hide tab

Browse Source 
* Crash is caused by dragging an autohide tab out when it is an icon
  only
* The crash can actually happen with non icon only tabs, but is masked
  by the orientation check

Base repository commit
61573cba1633600dddcbf5afb7d8ed1645f82b30

Change-Id: I1aebfd6455983662050aaf82a6506a6a5a40421e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Henning Gruendl
2023-08-30 16:46:41 +02:00
committed by Henning Gründl
parent 011ec75e88
commit 78cfd73037
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/libs/advanceddockingsystem/autohidetab.cpp
View File

@@ -408,7 +408,8 @@ void AutoHideTab::mouseReleaseEvent(QMouseEvent *event)
case DraggingFloatingWidget: case DraggingFloatingWidget:
event->accept(); event->accept();
d->m_floatingWidget->finishDragging(); d->m_floatingWidget->finishDragging();
if (d->m_dockWidget->isAutoHide() && d->m_dragStartOrientation != orientation()) if (d->m_dockWidget->autoHideDockContainer()
&& d->m_dragStartOrientation != orientation())
d->m_dockWidget->autoHideDockContainer()->resetToInitialDockWidgetSize(); d->m_dockWidget->autoHideDockContainer()->resetToInitialDockWidgetSize();
break; break;