feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Remove expensive checks in formeditor

Browse Source 
Change-Id: I6a08f1446962c890b6e4e75060dd795b12b19157
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Marco Bubke
2025-05-24 16:15:54 +02:00
parent 4a697a6099
commit 7d689e6305
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/qmldesigner/components/formeditor/formeditorview.cpp
View File

@@ -705,7 +705,8 @@ void FormEditorView::instancesCompleted(const QVector<ModelNode> &completedNodeL
const bool isFlow = QmlItemNode(rootModelNode()).isFlowView(); const bool isFlow = QmlItemNode(rootModelNode()).isFlowView();
QList<FormEditorItem*> itemNodeList; QList<FormEditorItem*> itemNodeList;
for (const ModelNode &node : completedNodeList) { for (const ModelNode &node : completedNodeList) {
if (const QmlItemNode qmlItemNode = (node)) { if (node) {
const QmlItemNode qmlItemNode = node;
if (FormEditorItem *item = scene()->itemForQmlItemNode(qmlItemNode)) { if (FormEditorItem *item = scene()->itemForQmlItemNode(qmlItemNode)) {
scene()->synchronizeParent(qmlItemNode); scene()->synchronizeParent(qmlItemNode);
itemNodeList.append(item); itemNodeList.append(item);
@@ -873,7 +874,7 @@ void FormEditorView::instancePropertyChanged(const QList<QPair<ModelNode, Proper
for (auto &nodePropertyPair : propertyList) { for (auto &nodePropertyPair : propertyList) {
const QmlItemNode qmlItemNode(nodePropertyPair.first); const QmlItemNode qmlItemNode(nodePropertyPair.first);
const PropertyName propertyName = nodePropertyPair.second; const PropertyName propertyName = nodePropertyPair.second;
if (qmlItemNode.isValid()) { if (qmlItemNode.modelNode().isValid()) {
if (FormEditorItem *item = scene()->itemForQmlItemNode(qmlItemNode)) { if (FormEditorItem *item = scene()->itemForQmlItemNode(qmlItemNode)) {
static const PropertyNameList skipList({"x", "y", "width", "height"}); static const PropertyNameList skipList({"x", "y", "width", "height"});
if (!skipList.contains(propertyName)) { if (!skipList.contains(propertyName)) {