feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

WelcomePage: fix memory leak

Browse Source 
I use AutoReleased now.

Change-Id: I4fd5d04115ea8d0a04d3e7f5c4e96a934b5ae134
Reviewed-on: http://codereview.qt-project.org/5712
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
This commit is contained in:
Thomas Hartmann
2011-09-28 13:41:44 +02:00
parent d056d20031
commit 7d96ba70c9
2 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/plugins/qtsupport/qtsupportplugin.cpp
View File

@@ -47,12 +47,6 @@
using namespace QtSupport;
using namespace QtSupport::Internal;
QtSupportPlugin::~QtSupportPlugin()
{
removeObject(m_welcomePage);
delete m_welcomePage;
}
bool QtSupportPlugin::initialize(const QStringList &arguments, QString *errorMessage)
{
Q_UNUSED(arguments);
@@ -65,12 +59,13 @@ bool QtSupportPlugin::initialize(const QStringList &arguments, QString *errorMes
addAutoReleasedObject(mgr);
addAutoReleasedObject(new QtOptionsPage);
m_welcomePage = new GettingStartedWelcomePage;
addObject(m_welcomePage);
GettingStartedWelcomePage *welcomePage;
welcomePage = new GettingStartedWelcomePage;
addAutoReleasedObject(welcomePage);
m_welcomePage = new GettingStartedWelcomePage;
m_welcomePage->setShowExamples(true);
addObject(m_welcomePage);
welcomePage = new GettingStartedWelcomePage;
welcomePage->setShowExamples(true);
addAutoReleasedObject(welcomePage);
return true;
}

3
src/plugins/qtsupport/qtsupportplugin.h
View File

@@ -47,7 +47,6 @@ class QtSupportPlugin : public ExtensionSystem::IPlugin
Q_OBJECT
public:
~QtSupportPlugin();
bool initialize(const QStringList &arguments, QString *errorMessage);
void extensionsInitialized();
@@ -56,8 +55,6 @@ private slots:
void testQtOutputParser_data();
void testQtOutputParser();
#endif
private:
GettingStartedWelcomePage *m_welcomePage;
};
} // namespace Internal