feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

iOS: Some IosDeployStep cosmetics

Browse Source 
Change-Id: If9834af39b9c06373da472b3e0624051730f785a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2020-02-18 17:50:44 +01:00
parent 989b44d911
commit 7dbf2c01c7
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/ios/iosdeploystep.cpp
View File

@@ -142,7 +142,7 @@ bool IosDeployStep::init()
void IosDeployStep::doRun() void IosDeployStep::doRun()
{ {
QTC_CHECK(m_transferStatus == NoTransfer); QTC_CHECK(m_transferStatus == NoTransfer);
if (device().isNull()) { if (m_device.isNull()) {
TaskHub::addTask( TaskHub::addTask(
DeploymentTask(Task::Error, tr("Deployment failed. No iOS device found."))); DeploymentTask(Task::Error, tr("Deployment failed. No iOS device found.")));
emit finished(!iossimulator().isNull()); emit finished(!iossimulator().isNull());
@@ -283,9 +283,9 @@ void IosDeployStep::checkProvisioningProfile()
if (!provisionPlist.contains(QLatin1String("ProvisionedDevices"))) if (!provisionPlist.contains(QLatin1String("ProvisionedDevices")))
return; return;
QStringList deviceIds = provisionPlist.value(QLatin1String("ProvisionedDevices")).toStringList(); const QStringList deviceIds = provisionPlist.value("ProvisionedDevices").toStringList();
QString targetId = device->uniqueDeviceID(); const QString targetId = device->uniqueDeviceID();
foreach (const QString &deviceId, deviceIds) { for (const QString &deviceId : deviceIds) {
if (deviceId == targetId) if (deviceId == targetId)
return; return;
} }
@@ -301,11 +301,6 @@ void IosDeployStep::checkProvisioningProfile()
emit addTask(task); emit addTask(task);
} }
IDevice::ConstPtr IosDeployStep::device() const
{
return m_device;
}
IosDevice::ConstPtr IosDeployStep::iosdevice() const IosDevice::ConstPtr IosDeployStep::iosdevice() const
{ {
return m_device.dynamicCast<const IosDevice>(); return m_device.dynamicCast<const IosDevice>();