feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Delete unnecessary class instances

Browse Source 
OutlineWidgetStack inherits from QStackedWidget, so you don't need a
member object like QStackedWidget.

The m_Factory object is not used in the OutlineWidgetStack class, is
of private type, and is not available in its OutlineWidgetStack
derived class.

Change-Id: I0b94a654dde023144f01e0bd7808ad5cc1dc92b8
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Li Xi
2021-09-17 19:24:41 +08:00
committed by lixi
parent 2695bcb167
commit 7e39f818c2
2 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/texteditor/outlinefactory.cpp
View File

@@ -62,8 +62,6 @@ void IOutlineWidgetFactory::updateOutline()
namespace Internal { namespace Internal {
OutlineWidgetStack::OutlineWidgetStack(OutlineFactory *factory) : OutlineWidgetStack::OutlineWidgetStack(OutlineFactory *factory) :
QStackedWidget(),
m_factory(factory),
m_syncWithEditor(true), m_syncWithEditor(true),
m_sorted(false) m_sorted(false)
{ {

2
src/plugins/texteditor/outlinefactory.h
View File

@@ -58,8 +58,6 @@ private:
void updateEditor(Core::IEditor *editor); void updateEditor(Core::IEditor *editor);
void updateCurrentEditor(); void updateCurrentEditor();
QStackedWidget *m_widgetStack;
OutlineFactory *m_factory;
QToolButton *m_toggleSync; QToolButton *m_toggleSync;
QToolButton *m_filterButton; QToolButton *m_filterButton;
QToolButton *m_toggleSort; QToolButton *m_toggleSort;