feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Core: Turn the IDE revision link in VersionDialog to be Opt-in

Browse Source 
If IDE_REVISION is set, don't default to some hardcoded string
for IDE_REVISION_IDE_STR.

Task-number: QTCREATORBUG-23524
Change-Id: Icc6aa6a4a0fb24178c5c1bd5feaa96b6a5b07115
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Alessandro Portale
2020-02-08 00:20:53 +01:00
parent ce40e13e3a
commit 8228d43579
2 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cmake/QtCreatorIDEBranding.cmake
View File

@@ -12,6 +12,3 @@ set(IDE_DISPLAY_NAME "Qt Creator") # The IDE display name.
set(IDE_ID "qtcreator") # The IDE id (no spaces, lowercase!)
set(IDE_CASED_ID "QtCreator") # The cased IDE id (no spaces!)
set(IDE_BUNDLE_IDENTIFIER "org.qt-project.${IDE_ID}") # The macOS application bundle identifier.
set(IDE_REVISION_URL_STR "https://code.qt.io/cgit/qt-creator/qt-creator.git/log/?id=%1")
# The revision url in the version dialog

2
src/app/app_version.h.in
View File

@@ -57,7 +57,7 @@ const char IDE_REVISION_STR[] = \"\";
#ifdef IDE_REVISION_URL
const char IDE_REVISION_URL_STR[] = STRINGIFY(IDE_REVISION_URL);
#else
const char IDE_REVISION_URL_STR[] = \"https://code.qt.io/cgit/qt-creator/qt-creator.git/log/?id=%1\";
const char IDE_REVISION_URL_STR[] = \"\";
#endif
// changes the path where the settings are saved to