feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Reduce usage of QStringRef::toString() in project manager/cmake.

Browse Source 
Change-Id: I5d60c663d8a258334dde9b93b4f76a4bea760a70
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
This commit is contained in:
Friedemann Kleint
2013-08-29 11:01:22 +02:00
parent e43e466b5b
commit 84cfc4f914
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cmakeprojectmanager/cmakeproject.cpp
View File

@@ -969,7 +969,7 @@ void CMakeCbpParser::parseBuildTargetOption()
if (attributes().hasAttribute(QLatin1String("output"))) {
m_buildTarget.executable = attributes().value(QLatin1String("output")).toString();
} else if (attributes().hasAttribute(QLatin1String("type"))) {
const QString value = attributes().value(QLatin1String("type")).toString();
const QStringRef value = attributes().value(QLatin1String("type"));
if (value == QLatin1String("2") || value == QLatin1String("3"))
m_buildTarget.library = true;
} else if (attributes().hasAttribute(QLatin1String("working_dir"))) {

8
src/plugins/projectexplorer/customwizard/customwizardparameters.cpp
View File

@@ -503,7 +503,7 @@ static inline FeatureSet requiredFeatures(const QXmlStreamReader &reader)
static inline IWizard::WizardFlags wizardFlags(const QXmlStreamReader &reader)
{
IWizard::WizardFlags flags;
QString value = reader.attributes().value(QLatin1String(platformIndependentC)).toString();
const QStringRef value = reader.attributes().value(QLatin1String(platformIndependentC));
if (!value.isEmpty() && value == QLatin1String("true"))
flags |= IWizard::PlatformIndependent;
@@ -530,14 +530,14 @@ static inline bool booleanAttributeValue(const QXmlStreamReader &r, const char *
static inline int integerAttributeValue(const QXmlStreamReader &r, const char *name, int defaultValue)
{
const QString sValue = r.attributes().value(QLatin1String(name)).toString();
const QStringRef sValue = r.attributes().value(QLatin1String(name));
if (sValue.isEmpty())
return defaultValue;
bool ok;
const int value = sValue.toInt(&ok);
const int value = sValue.toString().toInt(&ok);
if (!ok) {
qWarning("Invalid integer value specification '%s' for attribute '%s'.",
qPrintable(sValue), name);
qPrintable(sValue.toString()), name);
return defaultValue;
}
return value;