feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppEditor: Remove invalid QTC_ASSERTs in signature synchronizer

Browse Source 
They were triggered for

    void f(void);
    void f() {} // add space in parameter list to trigger

Change-Id: I410f3ac13380429a1803b95576afa92fef1fe4cf
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@theqtcompany.com>
This commit is contained in:
Nikolai Kosjar
2014-11-05 10:24:40 +01:00
parent d23d81f951
commit 85ead5f0da
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/cppeditor/cppfunctiondecldeflink.cpp
View File

@@ -672,8 +672,10 @@ ChangeSet FunctionDeclDefLink::changes(const Snapshot &snapshot, int targetOffse
// the number of parameters in sourceFunction or targetFunction
const int existingParamCount = declaredParameterCount(sourceFunction);
QTC_ASSERT(existingParamCount == declaredParameterCount(targetFunction), return changes);
QTC_ASSERT(existingParamCount == targetParameterDecls.size(), return changes);
if (existingParamCount != declaredParameterCount(targetFunction))
return changes;
if (existingParamCount != targetParameterDecls.size())
return changes;
const int newParamCount = declaredParameterCount(newFunction);