feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner.NodeInstances: Workaround qml design bug

Browse Source 
Task-number: QTCREATORBUG-5005

Change-Id: Ia0f1f30a04818bc6ee55a0822eaf0d2b0183e50d
Reviewed-on: http://codereview.qt.nokia.com/1252
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Marco Bubke <marco.bubke@nokia.com>
This commit is contained in:
Marco Bubke
2011-07-06 21:03:13 +02:00
parent 600127e875
commit 862bc044df
3 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
share/qtcreator/qml/qmlpuppet/qmlpuppet/instances/graphicsobjectnodeinstance.cpp
View File

@@ -45,6 +45,7 @@ GraphicsObjectNodeInstance::GraphicsObjectNodeInstance(QGraphicsObject *graphics
: ObjectNodeInstance(graphicsObject),
m_isMovable(true)
{
QGraphicsItemPrivate::get(graphicsObject)->sendParentChangeNotification = 1;
}
QGraphicsObject *GraphicsObjectNodeInstance::graphicsObject() const

21
share/qtcreator/qml/qmlpuppet/qmlpuppet/instances/qmlgraphicsitemnodeinstance.cpp
View File

@@ -207,13 +207,24 @@ void QmlGraphicsItemNodeInstance::refresh()
repositioning(qmlGraphicsItem());
}
void QmlGraphicsItemNodeInstance::recursiveDoComponentComplete(QGraphicsItem *item)
{
QGraphicsObject *graphicsObject = item->toGraphicsObject();
QDeclarativeItem *declarativeItem = qobject_cast<QDeclarativeItem*>(graphicsObject);
if (declarativeItem && !nodeInstanceServer()->hasInstanceForObject(declarativeItem)) {
if (QDeclarativeItemPrivate::get(qmlGraphicsItem())->componentComplete)
return;
static_cast<QDeclarativeParserStatus*>(qmlGraphicsItem())->componentComplete();
foreach (QGraphicsItem *childItem, item->childItems())
recursiveDoComponentComplete(childItem);
}
}
void QmlGraphicsItemNodeInstance::doComponentComplete()
{
if (qmlGraphicsItem()) {
if (static_cast<QDeclarativeItemPrivate*>(QGraphicsItemPrivate::get(qmlGraphicsItem()))->componentComplete)
return;
static_cast<QDeclarativeParserStatus*>(qmlGraphicsItem())->componentComplete();
QGraphicsItemPrivate::get(qmlGraphicsItem())->sendParentChangeNotification = 1;
recursiveDoComponentComplete(qmlGraphicsItem());
}
graphicsObject()->update();
@@ -301,7 +312,9 @@ void QmlGraphicsItemNodeInstance::reparent(const ObjectNodeInstance::Pointer &ol
setMovable(true);
}
QDeclarativeItemPrivate::get(qmlGraphicsItem())->componentComplete = 1;
GraphicsObjectNodeInstance::reparent(oldParentInstance, oldParentProperty, newParentInstance, newParentProperty);
QDeclarativeItemPrivate::get(qmlGraphicsItem())->componentComplete = 0;
if (newParentInstance && newParentInstance->isPositioner()) {
setInPositioner(true);

1
share/qtcreator/qml/qmlpuppet/qmlpuppet/instances/qmlgraphicsitemnodeinstance.h
View File

@@ -85,6 +85,7 @@ protected:
void resetHorizontal();
void resetVertical();
void refresh();
void recursiveDoComponentComplete(QGraphicsItem *item);
private: //variables
bool m_hasHeight;