feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Build: Only state direct dependencies in plugin spec

Browse Source 
There is no need to state dependencies in the plugin meta data
recursively, they are resolved recursively in the end anyway.

This reduces the effort that we do in CMake during configure time.

Change-Id: Ic3161a405f6c13ba09cfc3211f03c4b4426afbc8
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This commit is contained in:
Eike Ziller
2024-09-04 12:57:43 +02:00
parent 44678d5502
commit 88f8d5c5e0
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cmake/QtCreatorAPI.cmake
View File

@@ -392,12 +392,10 @@ function(add_qtc_plugin target_name)
find_dependent_plugins(_DEP_PLUGINS ${_arg_PLUGIN_DEPENDS})
set(_arg_DEPENDENCY_STRING "\"Dependencies\" : [\n")
foreach(i IN LISTS _DEP_PLUGINS)
foreach(i IN LISTS _arg_PLUGIN_DEPENDS)
get_property(_v TARGET "${i}" PROPERTY QTC_PLUGIN_VERSION)
if (i MATCHES "^QtCreator::")
set(_v ${IDE_VERSION})
string(REPLACE "QtCreator::" "" i ${i})
else()
get_property(_v TARGET "${i}" PROPERTY QTC_PLUGIN_VERSION)
endif()
string(TOLOWER ${i} i)
string(APPEND _arg_DEPENDENCY_STRING
@@ -405,11 +403,9 @@ function(add_qtc_plugin target_name)
)
endforeach(i)
foreach(i IN LISTS _arg_PLUGIN_RECOMMENDS)
get_property(_v TARGET "${i}" PROPERTY QTC_PLUGIN_VERSION)
if (i MATCHES "^QtCreator::")
set(_v ${IDE_VERSION})
string(REPLACE "QtCreator::" "" i ${i})
else()
get_property(_v TARGET "${i}" PROPERTY QTC_PLUGIN_VERSION)
endif()
string(TOLOWER ${i} i)
string(APPEND _arg_DEPENDENCY_STRING