feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Make more classes final

Browse Source 
Because the interface is for dependency injection only the
implementation should be always final.

Change-Id: I069126d8767b0e1072c1e938acb42086abed4a1e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
This commit is contained in:
Marco Bubke
2023-06-01 20:27:13 +02:00
parent 278d69df4f
commit 898a7cbc88
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/qmldesigner/designercore/projectstorage/projectstorageupdater.h
View File

@@ -32,7 +32,7 @@ class ProjectStorage;
class QmlDocumentParserInterface; class QmlDocumentParserInterface;
class QmlTypesParserInterface; class QmlTypesParserInterface;
class ProjectStorageUpdater : public ProjectStoragePathWatcherNotifierInterface class ProjectStorageUpdater final : public ProjectStoragePathWatcherNotifierInterface
{ {
public: public:
using PathCache = SourcePathCache<ProjectStorage<Sqlite::Database>, NonLockingMutex>; using PathCache = SourcePathCache<ProjectStorage<Sqlite::Database>, NonLockingMutex>;

2
src/plugins/qmldesigner/designercore/projectstorage/qmldocumentparser.h
View File

@@ -12,7 +12,7 @@ namespace QmlDesigner {
template<typename ProjectStorage, typename Mutex> template<typename ProjectStorage, typename Mutex>
class SourcePathCache; class SourcePathCache;
class QmlDocumentParser : public QmlDocumentParserInterface class QmlDocumentParser final : public QmlDocumentParserInterface
{ {
public: public:
using ProjectStorage = QmlDesigner::ProjectStorage<Sqlite::Database>; using ProjectStorage = QmlDesigner::ProjectStorage<Sqlite::Database>;

2
src/plugins/qmldesigner/designercore/projectstorage/qmltypesparser.h
View File

@@ -18,7 +18,7 @@ class ProjectStorage;
template<typename ProjectStorage, typename Mutex> template<typename ProjectStorage, typename Mutex>
class SourcePathCache; class SourcePathCache;
class QmlTypesParser : public QmlTypesParserInterface class QmlTypesParser final : public QmlTypesParserInterface
{ {
public: public:
using ProjectStorage = QmlDesigner::ProjectStorage<Sqlite::Database>; using ProjectStorage = QmlDesigner::ProjectStorage<Sqlite::Database>;