feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangCodemodel: Avoid repeated construction of category prefixes

Browse Source 
Change-Id: I0166010a17f1f37855862f28cc9e2472b638c9de
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
hjk
2022-08-03 14:27:18 +02:00
parent 057bb3095b
commit 8ae55344de
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/clangcodemodel/clangutils.cpp
View File

@@ -76,15 +76,14 @@ QString diagnosticCategoryPrefixRemoved(const QString &text)
// Prefixes are taken from $LLVM_SOURCE_DIR/tools/clang/lib/Frontend/TextDiagnostic.cpp, // Prefixes are taken from $LLVM_SOURCE_DIR/tools/clang/lib/Frontend/TextDiagnostic.cpp,
// function TextDiagnostic::printDiagnosticLevel (llvm-3.6.2). // function TextDiagnostic::printDiagnosticLevel (llvm-3.6.2).
static const QStringList categoryPrefixes = { static const QStringList categoryPrefixes = {
QStringLiteral("note"), QStringLiteral("note: "),
QStringLiteral("remark"), QStringLiteral("remark: "),
QStringLiteral("warning"), QStringLiteral("warning: "),
QStringLiteral("error"), QStringLiteral("error: "),
QStringLiteral("fatal error") QStringLiteral("fatal error: ")
}; };
for (const QString &prefix : categoryPrefixes) { for (const QString &fullPrefix : categoryPrefixes) {
const QString fullPrefix = prefix + QStringLiteral(": ");
if (theText.startsWith(fullPrefix)) { if (theText.startsWith(fullPrefix)) {
theText.remove(0, fullPrefix.length()); theText.remove(0, fullPrefix.length());
return theText; return theText;