feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Android: Pass const reference instead of a copy

Browse Source 
Change-Id: I5058478c99b6316c836003239490c606ca0efb4b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Jarek Kobus
2024-05-03 11:05:16 +02:00
parent d356257bd6
commit 8b87f8f0b7
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/android/androidrunnerworker.cpp
View File

@@ -83,7 +83,7 @@ static qint64 extractPID(const QString &output, const QString &packageName)
} }
static void findProcessPIDAndUser(QPromise<PidUserPair> &promise, static void findProcessPIDAndUser(QPromise<PidUserPair> &promise,
QStringList selector, const QStringList &selector,
const QString &packageName, const QString &packageName,
bool preNougat) bool preNougat)
{ {
@@ -821,7 +821,7 @@ void AndroidRunnerWorker::removeForwardPort(const QString &port)
} }
} }
void AndroidRunnerWorker::onProcessIdChanged(PidUserPair pidUser) void AndroidRunnerWorker::onProcessIdChanged(const PidUserPair &pidUser)
{ {
// Don't write to m_psProc from a different thread // Don't write to m_psProc from a different thread
QTC_ASSERT(QThread::currentThread() == thread(), return); QTC_ASSERT(QThread::currentThread() == thread(), return);

2
src/plugins/android/androidrunnerworker.h
View File

@@ -75,7 +75,7 @@ private:
Waiting, Waiting,
Settled Settled
}; };
void onProcessIdChanged(PidUserPair pidUser); void onProcessIdChanged(const PidUserPair &pidUser);
// Create the processes and timer in the worker thread, for correct thread affinity // Create the processes and timer in the worker thread, for correct thread affinity
bool m_isPreNougat = false; bool m_isPreNougat = false;