feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix the runtime warning when building against Qt 5

Browse Source 
It fixes the following warning:
QObject::connect: Cannot queue arguments of type 'FilePath'
(Make sure 'FilePath' is registered using qRegisterMetaType().)

It looks like with Qt 5 all arguments needs to be specified
with full namespace in order to be used in queued connections.
Note, that warning is misleading as adding qRegisterMetaType()
doesn't fix it in this case.

The full scope isn't needed when building against Qt 6,
so leaving a TODO for Creator 9.0

Change-Id: I43a52385b8d3bb0ef90ce274e11df9fd68e62109
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2022-07-11 10:25:50 +02:00
parent def3cb70ab
commit 8bc6cf3f98
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/libs/utils/shellcommand.h
View File

@@ -149,7 +149,8 @@ signals:
void append(const QString &text); void append(const QString &text);
void appendSilently(const QString &text); void appendSilently(const QString &text);
void appendError(const QString &text); void appendError(const QString &text);
void appendCommand(const FilePath &workingDirectory, const CommandLine &command); // TODO: remove Utils:: scope when support for Qt5 is dropped (Creator 9.0)
void appendCommand(const Utils::FilePath &workingDirectory, const Utils::CommandLine &command);
void appendMessage(const QString &text); void appendMessage(const QString &text);
protected: protected: