feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CodeAssist: Initialize locals and member after early return.

Browse Source 
Change-Id: Iec850ccbb6461b581fd2347006e6dfc8a0b605a7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
David Schulz
2016-03-14 13:10:19 +01:00
parent 70399d4030
commit 8d2858d8fe
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/texteditor/codeassist/codeassistant.cpp
View File

@@ -223,13 +223,12 @@ void CodeAssistantPrivate::requestProposal(AssistReason reason,
return; return;
} }
AssistInterface *assistInterface = m_editorWidget->createAssistInterface(kind, reason);
if (!assistInterface)
return;
m_assistKind = kind; m_assistKind = kind;
IAssistProcessor *processor = provider->createProcessor(); IAssistProcessor *processor = provider->createProcessor();
AssistInterface *assistInterface = m_editorWidget->createAssistInterface(kind, reason);
if (!assistInterface) {
delete processor;
return;
}
switch (provider->runType()) { switch (provider->runType()) {
case IAssistProvider::Synchronous: { case IAssistProvider::Synchronous: {