feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Project: Remove knowsAllBuildExecutables feature

Browse Source 
This is feature is no longer needed.

Change-Id: Ia0798402fcb4c06fb4dd38225359738306211176
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Cristian Adam
2021-06-28 16:39:23 +02:00
parent 18f24ffd68
commit 8ed5836746
5 changed files with 1 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/cmakeprojectmanager/cmakeproject.cpp
View File

@@ -58,7 +58,6 @@ CMakeProject::CMakeProject(const FilePath &fileName)
setProjectLanguages(Core::Context(ProjectExplorer::Constants::CXX_LANGUAGE_ID));
setDisplayName(projectDirectory().fileName());
setCanBuildProducts();
setKnowsAllBuildExecutables(true);
setHasMakeInstallEquivalent(true);
}

1
src/plugins/mesonprojectmanager/project/mesonproject.cpp
View File

@@ -47,7 +47,6 @@ MesonProject::MesonProject(const Utils::FilePath &path)
setProjectLanguages(Core::Context(ProjectExplorer::Constants::CXX_LANGUAGE_ID));
setDisplayName(projectDirectory().fileName());
setCanBuildProducts();
setKnowsAllBuildExecutables(true);
setHasMakeInstallEquivalent(true);
}

11
src/plugins/projectexplorer/project.cpp
View File

@@ -183,7 +183,6 @@ public:
Utils::Id m_id;
bool m_needsInitialExpansion = false;
bool m_canBuildProducts = false;
bool m_knowsAllBuildExecutables = true;
bool m_hasMakeInstallEquivalent = false;
bool m_needsBuildConfigurations = true;
bool m_needsDeployConfigurations = true;
@@ -903,11 +902,6 @@ void Project::setHasMakeInstallEquivalent(bool enabled)
d->m_hasMakeInstallEquivalent = enabled;
}
void Project::setKnowsAllBuildExecutables(bool value)
{
d->m_knowsAllBuildExecutables = value;
}
void Project::setNeedsBuildConfigurations(bool value)
{
d->m_needsBuildConfigurations = value;
@@ -976,11 +970,6 @@ void Project::configureAsExampleProject(Kit * /*kit*/)
{
}
bool Project::knowsAllBuildExecutables() const
{
return d->m_knowsAllBuildExecutables;
}
bool Project::hasMakeInstallEquivalent() const
{
return d->m_hasMakeInstallEquivalent;

5
src/plugins/projectexplorer/project.h
View File

@@ -147,10 +147,6 @@ public:
virtual ProjectImporter *projectImporter() const;
// The build system is able to report all executables that can be built, independent
// of configuration.
bool knowsAllBuildExecutables() const;
virtual DeploymentKnowledge deploymentKnowledge() const { return DeploymentKnowledge::Bad; }
bool hasMakeInstallEquivalent() const;
virtual MakeInstallCommand makeInstallCommand(const Target *target, const QString &installRoot);
@@ -228,7 +224,6 @@ protected:
void removeProjectLanguage(Utils::Id id);
void setHasMakeInstallEquivalent(bool enabled);
void setKnowsAllBuildExecutables(bool value);
void setNeedsBuildConfigurations(bool value);
void setNeedsDeployConfigurations(bool value);

2
src/plugins/projectexplorer/target.cpp
View File

@@ -684,7 +684,7 @@ void Target::updateDefaultRunConfigurations()
present = true;
}
}
if (!present && project()->knowsAllBuildExecutables())
if (!present)
toRemove.append(rc);
}
configuredCount -= toRemove.count();