feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

StudioWelcome: Remove unused code and fix return value

Browse Source 
The connection to visibleChanged of the main window doesn't do anything,
since its visibility doesn't change as long as the splash screen is
showing.

Also return false from delayedInitialize() if it doesn't do anything.
Returning true requests that the next plugin's delayedInitialize() is
actually delayed, which doesn't make sense it didn't do anything.

Change-Id: I96793ce6df517bf37b3b060e80daf8cc74d71247
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Eike Ziller
2020-06-02 15:54:59 +02:00
parent b07909d9fd
commit 9031ad19c4
1 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/studiowelcome/studiowelcomeplugin.cpp
View File

@@ -259,21 +259,11 @@ void StudioWelcomePlugin::extensionsInitialized()
bool StudioWelcomePlugin::delayedInitialize() bool StudioWelcomePlugin::delayedInitialize()
{ {
if (s_view.isNull()) if (s_view.isNull())
return true; return false;
QTC_ASSERT(s_view->rootObject() , return true); QTC_ASSERT(s_view->rootObject() , return true);
s_view->rootObject()->setProperty("loadingPlugins", false); s_view->rootObject()->setProperty("loadingPlugins", false);
QPointer<QQuickWidget> view = s_view;
connect(Core::ICore::mainWindow()->windowHandle(), &QWindow::visibleChanged, this, [view](){
if (!view.isNull()) {
view->close();
view->deleteLater();
}
});
return false; return false;
} }