feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Remove gtest notes from visual tree

Browse Source 
GTest uses a linear output format while we use a tree to
group the results.
Some information which make sense for the linear result
cannot be placed correctly into the visual tree at all
without breaking either the tree layout or displaying the
result at unexpected locations inside the tree.
So, omitting these information to avoid confusion seems
to be the best trade-off as the information is still
present inside the text output if needed.

Change-Id: Ifd72bbf7e88993b4c76765597288e1531b50ee9a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Stenger
2023-02-20 15:45:46 +01:00
parent f9b6ee54d8
commit 919b97b750
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/autotest/gtest/gtestoutputreader.cpp
View File

@@ -69,13 +69,8 @@ void GTestOutputReader::processOutputLine(const QByteArray &outputLine)
m_iteration = match.captured(1).toInt();
m_description.clear();
} else if (line.startsWith(QStringLiteral("Note:"))) {
m_description = line;
if (m_iteration > 1)
m_description.append(' ' + Tr::tr("(iteration %1)").arg(m_iteration));
GTestResult testResult(id(), {}, m_projectFile);
testResult.setResult(ResultType::MessageInternal);
testResult.setDescription(m_description);
reportResult(testResult);
// notes contain insignificant information we fail to include properly into the
// visual tree, so ignore them here as they are available inside the text display anyhow
m_description.clear();
} else if (ExactMatch match = disabledTests.match(line)) {
m_disabled = match.captured(1).toInt();