feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Help: All candidates (considering name qualification) are already in the list.

Browse Source 
The C++ hover handler should just iterate over the list of candidates, since
it was created by the element evaluator considering all possible name qualifications
and in the right order.

Reviewed-by: kh1
This commit is contained in:
Leandro Melo
2010-10-01 11:54:35 +02:00
parent 3e104ce405
commit 922e8e7866
1 changed files with 1 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/plugins/cppeditor/cpphoverhandler.cpp
View File

@@ -46,16 +46,6 @@
using namespace CppEditor::Internal;
using namespace Core;
namespace {
QString removeClassNameQualification(const QString &name) {
const int index = name.lastIndexOf(QLatin1Char(':'));
if (index == -1)
return name;
else
return name.right(name.length() - index - 1);
}
}
CppHoverHandler::CppHoverHandler(QObject *parent) : BaseHoverHandler(parent)
{}
@@ -87,16 +77,8 @@ void CppHoverHandler::identifyMatch(TextEditor::ITextEditor *editor, int pos)
QSharedPointer<CppElement> cppElement = evaluator.identifyCppElement();
if (!cppElement.isNull()) {
setToolTip(cppElement->tooltip());
foreach (QString helpId, cppElement->helpIdCandidates()) {
bool found = false;
foreach (const QString &helpId, cppElement->helpIdCandidates()) {
if (!Core::HelpManager::instance()->linksForIdentifier(helpId).isEmpty()) {
found = true;
} else {
helpId = removeClassNameQualification(helpId);
if (!Core::HelpManager::instance()->linksForIdentifier(helpId).isEmpty())
found = true;
}
if (found) {
setLastHelpItemIdentified(TextEditor::HelpItem(helpId,
cppElement->helpMark(),
cppElement->helpCategory()));