Valgrind: Fix cyclic connect

Editing the widget triggers rawPathChanged(), which calls
setValgrindExecutable, which emits valgrindExecutableChanged(), which calls
setPath on the widget.

No other path reaches any of these functions.

This causes the cursor to jump to the end, so if you want to change
'valgrind' to '/usr/local/bin/valgrind' you have to jump back after each
character.

Removed the now unused signal.

Change-Id: Iaf4e902fb9a42975e9ada6662b7a64e53fab5cad
Reviewed-by: hjk <hjk@qt.io>

src/plugins/valgrind/valgrindconfigwidget.cpp

@@ -62,8 +62,6 @@ ValgrindConfigWidget::ValgrindConfigWidget(ValgrindBaseSettings *settings,
 
     connect(m_ui->valgrindExeChooser, &Utils::PathChooser::rawPathChanged,
             m_settings, &ValgrindBaseSettings::setValgrindExecutable);
-    connect(m_settings, &ValgrindBaseSettings::valgrindExecutableChanged,
-            m_ui->valgrindExeChooser, &Utils::PathChooser::setPath);
     connect(m_ui->smcDetectionComboBox, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
             m_settings, &ValgrindBaseSettings::setSelfModifyingCodeDetection);
 

src/plugins/valgrind/valgrindsettings.cpp

@@ -143,10 +143,7 @@ void ValgrindBaseSettings::toMap(QVariantMap &map) const
 
 void ValgrindBaseSettings::setValgrindExecutable(const QString &valgrindExecutable)
 {
-    if (m_valgrindExecutable != valgrindExecutable) {
-        m_valgrindExecutable = valgrindExecutable;
-        emit valgrindExecutableChanged(valgrindExecutable);
-    }
+    m_valgrindExecutable = valgrindExecutable;
 }
 
 void ValgrindBaseSettings::setSelfModifyingCodeDetection(int smcDetection)

src/plugins/valgrind/valgrindsettings.h

@@ -78,7 +78,6 @@ public:
     void setSelfModifyingCodeDetection(int);
 
 signals:
-    void valgrindExecutableChanged(const QString &);
     void selfModifyingCodeDetectionChanged(int);
 
 private: