ProjectExplorer: Use a Kit to initialize KitInfo

Change-Id: I70a83ff9a9da814b4e1ad9ce5e0b626105c09ca4
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>

src/plugins/autotoolsprojectmanager/autotoolsbuildsystem.cpp

@@ -175,7 +175,7 @@ static QStringList filterIncludes(const QString &absSrc, const QString &absBuild
 
 void AutotoolsBuildSystem::updateCppCodeModel()
 {
-    QtSupport::CppKitInfo kitInfo(project());
+    QtSupport::CppKitInfo kitInfo(kit());
     QTC_ASSERT(kitInfo.isValid(), return );
 
     const Utils::FilePath projectFilePath = project()->projectFilePath();

src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp

@@ -441,7 +441,7 @@ void CMakeBuildSystem::updateProjectData()
         qCDebug(cmakeBuildSystemLog) << "Extra compilers updated.";
     }
 
-    QtSupport::CppKitInfo kitInfo(p);
+    QtSupport::CppKitInfo kitInfo(kit());
     QTC_ASSERT(kitInfo.isValid(), return );
 
     {

src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.cpp

@@ -376,7 +376,7 @@ void CompilationDatabaseBuildSystem::triggerParsing()
 
 void CompilationDatabaseBuildSystem::buildTreeAndProjectParts()
 {
-    ProjectExplorer::KitInfo kitInfo(project());
+    ProjectExplorer::KitInfo kitInfo(kit());
     QTC_ASSERT(kitInfo.isValid(), return);
     // Reset toolchains to pick them based on the database entries.
     kitInfo.cToolChain = nullptr;

src/plugins/genericprojectmanager/genericproject.cpp

@@ -551,7 +551,7 @@ void GenericBuildSystem::refreshCppCodeModel()
 {
     if (!m_cppCodeModelUpdater)
         return;
-    QtSupport::CppKitInfo kitInfo(project());
+    QtSupport::CppKitInfo kitInfo(kit());
     QTC_ASSERT(kitInfo.isValid(), return);
 
     RawProjectPart rpp;

src/plugins/projectexplorer/buildsystem.cpp

@@ -90,6 +90,11 @@ Target *BuildSystem::target() const
     return d->m_target;
 }
 
+Kit *BuildSystem::kit() const
+{
+    return d->m_target->kit();
+}
+
 void BuildSystem::emitParsingStarted()
 {
     QTC_ASSERT(!d->m_isParsing, return);

src/plugins/projectexplorer/buildsystem.h

@@ -53,6 +53,7 @@ public:
 
     Project *project() const;
     Target *target() const;
+    Kit *kit() const;
 
     Utils::FilePath projectFilePath() const;
     Utils::FilePath projectDirectory() const;

src/plugins/projectexplorer/rawprojectpart.cpp

@@ -150,14 +150,9 @@ void RawProjectPart::setBuildTargetType(BuildTargetType type)
     buildTargetType = type;
 }
 
-KitInfo::KitInfo(Project *project)
+KitInfo::KitInfo(Kit *kit)
+    : kit(kit)
 {
-    // Kit
-    if (Target *target = project->activeTarget())
-        kit = target->kit();
-    else
-        kit = KitManager::defaultKit();
-
     // Toolchains
     if (kit) {
         cToolChain = ToolChainKitAspect::toolChain(kit, Constants::C_LANGUAGE_ID);

src/plugins/projectexplorer/rawprojectpart.h

@@ -125,7 +125,7 @@ using RawProjectParts = QVector<RawProjectPart>;
 class PROJECTEXPLORER_EXPORT KitInfo
 {
 public:
-    explicit KitInfo(Project *project);
+    explicit KitInfo(Kit *kit);
 
     bool isValid() const;
 

src/plugins/qbsprojectmanager/qbsproject.cpp

@@ -1012,7 +1012,7 @@ void QbsBuildSystem::updateCppCodeModel()
     qDeleteAll(m_extraCompilers);
     m_extraCompilers.clear();
 
-    QtSupport::CppKitInfo kitInfo(project());
+    QtSupport::CppKitInfo kitInfo(kit());
     QTC_ASSERT(kitInfo.isValid(), return);
 
     RawProjectParts rpps;

src/plugins/qmakeprojectmanager/qmakeproject.cpp

@@ -244,7 +244,7 @@ void QmakeBuildSystem::updateCppCodeModel()
 {
     m_toolChainWarnings.clear();
 
-    QtSupport::CppKitInfo kitInfo(project());
+    QtSupport::CppKitInfo kitInfo(kit());
     QTC_ASSERT(kitInfo.isValid(), return);
 
     QList<ProjectExplorer::ExtraCompiler *> generators;

src/plugins/qtsupport/qtcppkitinfo.cpp

@@ -30,8 +30,8 @@
 
 namespace QtSupport {
 
-CppKitInfo::CppKitInfo(ProjectExplorer::Project *project)
-    : ProjectExplorer::KitInfo(project)
+CppKitInfo::CppKitInfo(ProjectExplorer::Kit *kit)
+    : ProjectExplorer::KitInfo(kit)
 {
     if (kit && (qtVersion = QtKitAspect::qtVersion(kit))) {
         if (qtVersion->qtVersion() < QtSupport::QtVersionNumber(5, 0, 0))

src/plugins/qtsupport/qtcppkitinfo.h

@@ -36,7 +36,7 @@ class BaseQtVersion;
 class QTSUPPORT_EXPORT CppKitInfo : public ProjectExplorer::KitInfo
 {
 public:
-    CppKitInfo(ProjectExplorer::Project *project);
+    CppKitInfo(ProjectExplorer::Kit *kit);
 
     BaseQtVersion *qtVersion = nullptr;
 };