feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LSP: Fix logic to avoid nullptr access

Browse Source 
Change-Id: I5511d266b52b1bc1763bdf3cd430f49f30ae3f37
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Stenger
2021-05-28 09:56:24 +02:00
parent 9237f66bc9
commit 95ff7a6c80
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/libs/languageserverprotocol/completion.cpp
View File

@@ -45,8 +45,9 @@ Utils::optional<MarkupOrString> CompletionItem::documentation() const
Utils::optional<CompletionItem::InsertTextFormat> CompletionItem::insertTextFormat() const Utils::optional<CompletionItem::InsertTextFormat> CompletionItem::insertTextFormat() const
{ {
Utils::optional<int> value = optionalValue<int>(insertTextFormatKey); Utils::optional<int> value = optionalValue<int>(insertTextFormatKey);
return value.has_value() ? Utils::nullopt return value.has_value()
: Utils::make_optional(CompletionItem::InsertTextFormat(value.value())); ? Utils::make_optional(CompletionItem::InsertTextFormat(value.value()))
: Utils::nullopt;
} }
bool CompletionItem::isValid(ErrorHierarchy *error) const bool CompletionItem::isValid(ErrorHierarchy *error) const