feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

EditorToolBar: Replace optional::value by non-throwing alternative

Browse Source 
...to calm down static checker which
fears throwing exceptions into dtors

Change-Id: I7f1a298e8391735d503332a7bce67e10895fbc85
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Robert Loehning
2018-04-16 11:31:53 +02:00
parent 7be7d26814
commit 9636de7cd4
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/coreplugin/editortoolbar.cpp
View File

@@ -322,7 +322,7 @@ void EditorToolBar::setCurrentEditor(IEditor *editor)
IDocument *document = editor ? editor->document() : 0;
const Utils::optional<int> index = DocumentModel::rowOfDocument(document);
if (QTC_GUARD(index))
d->m_editorList->setCurrentIndex(index.value());
d->m_editorList->setCurrentIndex(*index);
// If we never added the toolbar from the editor, we will never change
// the editor, so there's no need to update the toolbar either.