feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Stop on every warning

Browse Source 
We already had some bugs because warnings were ignored. So we generate
errors now for the qml desinger plugins.

Task-number: QDS-9135
Change-Id: I9276a1b5cdbec554bc33c0c6ed3706817518f39c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Marco Bubke
2023-02-13 13:31:10 +01:00
parent 9b43e0caea
commit 96ea9e3891
3 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/qmldesigner/CMakeLists.txt
View File

@@ -11,6 +11,7 @@ option(USE_PROJECTSTORAGE "Use ProjectStorage" ${ENV_QDS_USE_PROJECTSTORAGE})
add_feature_info("ProjectStorage" ${USE_PROJECTSTORAGE} "") add_feature_info("ProjectStorage" ${USE_PROJECTSTORAGE} "")
add_qtc_library(QmlDesignerUtils STATIC add_qtc_library(QmlDesignerUtils STATIC
PROPERTIES COMPILE_WARNING_AS_ERROR ON
DEPENDS DEPENDS
Qt::Gui Utils Qt::QmlPrivate Qt::Gui Utils Qt::QmlPrivate
DEFINES QMLDESIGNERUTILS_LIBRARY DEFINES QMLDESIGNERUTILS_LIBRARY
@@ -405,6 +406,7 @@ set_property(SOURCE ${PROJECTSTORAGE_EXCLUDED_SOURCES} PROPERTY SKIP_AUTOMOC ON)
add_qtc_plugin(QmlDesigner add_qtc_plugin(QmlDesigner
CONDITION Qt6_VERSION VERSION_GREATER_EQUAL 6.2.0 AND TARGET Qt::QuickWidgets AND TARGET Qt::Svg CONDITION Qt6_VERSION VERSION_GREATER_EQUAL 6.2.0 AND TARGET Qt::QuickWidgets AND TARGET Qt::Svg
PROPERTIES COMPILE_WARNING_AS_ERROR ON
DEPENDS DEPENDS
QmlJS LanguageUtils QmlEditorWidgets AdvancedDockingSystem QmlJS LanguageUtils QmlEditorWidgets AdvancedDockingSystem
Qt::QuickWidgets Qt::CorePrivate Sqlite Qt::Xml Qt::Svg Qt::QuickWidgets Qt::CorePrivate Sqlite Qt::Xml Qt::Svg

1
src/plugins/qmldesignerbase/CMakeLists.txt
View File

@@ -1,4 +1,5 @@
add_qtc_plugin(QmlDesignerBase add_qtc_plugin(QmlDesignerBase
PROPERTIES COMPILE_WARNING_AS_ERROR ON
DEPENDS Qt::Core Qt::QuickWidgets DEPENDS Qt::Core Qt::QuickWidgets
PLUGIN_DEPENDS Core ProjectExplorer QtSupport PLUGIN_DEPENDS Core ProjectExplorer QtSupport
SOURCES SOURCES

1
src/plugins/qmlprojectmanager/CMakeLists.txt
View File

@@ -1,5 +1,6 @@
add_qtc_plugin(QmlProjectManager add_qtc_plugin(QmlProjectManager
CONDITION TARGET Qt5::QuickWidgets CONDITION TARGET Qt5::QuickWidgets
PROPERTIES COMPILE_WARNING_AS_ERROR ON
PLUGIN_CLASS QmlProjectPlugin PLUGIN_CLASS QmlProjectPlugin
DEPENDS QmlJS Qt5::QuickWidgets DEPENDS QmlJS Qt5::QuickWidgets
PLUGIN_DEPENDS Core ProjectExplorer QtSupport QmlDesignerBase PLUGIN_DEPENDS Core ProjectExplorer QtSupport QmlDesignerBase