feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VcsBase: Don't use QObject inheritance in VcsEditorFactory

Browse Source 
The only remaining use is a setProperty that's never read back
anymore after 9c96a1c4d.

Change-Id: I2c49b044bb97a123e72070df5e83909c53e40881
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2020-02-24 11:18:18 +01:00
parent 5c9141241b
commit 989b44d911
2 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/vcsbase/basevcseditorfactory.cpp
View File

@@ -54,7 +54,6 @@ VcsEditorFactory::VcsEditorFactory(const VcsBaseEditorParameters *parameters,
const EditorWidgetCreator editorWidgetCreator, const EditorWidgetCreator editorWidgetCreator,
std::function<void(const QString &, const QString &)> describeFunc) std::function<void(const QString &, const QString &)> describeFunc)
{ {
setProperty("VcsEditorFactoryName", QByteArray(parameters->id));
setId(parameters->id); setId(parameters->id);
setDisplayName(QCoreApplication::translate("VCS", parameters->displayName)); setDisplayName(QCoreApplication::translate("VCS", parameters->displayName));
if (QLatin1String(parameters->mimeType) != QLatin1String(DiffEditor::Constants::DIFF_EDITOR_MIMETYPE)) if (QLatin1String(parameters->mimeType) != QLatin1String(DiffEditor::Constants::DIFF_EDITOR_MIMETYPE))

2
src/plugins/vcsbase/basevcseditorfactory.h
View File

@@ -37,8 +37,6 @@ class VcsBaseEditorParameters;
class VCSBASE_EXPORT VcsEditorFactory : public TextEditor::TextEditorFactory class VCSBASE_EXPORT VcsEditorFactory : public TextEditor::TextEditorFactory
{ {
Q_OBJECT
public: public:
VcsEditorFactory(const VcsBaseEditorParameters *parameters, VcsEditorFactory(const VcsBaseEditorParameters *parameters,
const EditorWidgetCreator editorWidgetCreator, const EditorWidgetCreator editorWidgetCreator,