feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Project: Remove unused Project::requiresTargetPanel(...)

Browse Source 
Change-Id: I7a5298edefd7e26841c4070be23534dd33d093cb
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Tobias Hunger
2018-02-16 12:45:43 +01:00
parent 775b235f45
commit 997ece4361
7 changed files with 0 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/cmakeprojectmanager/cmakeproject.cpp
View File

@@ -366,11 +366,6 @@ bool CMakeProject::needsConfiguration() const
return targets().isEmpty(); return targets().isEmpty();
} }
bool CMakeProject::requiresTargetPanel() const
{
return !targets().isEmpty();
}
bool CMakeProject::knowsAllBuildExecutables() const bool CMakeProject::knowsAllBuildExecutables() const
{ {
return false; return false;

1
src/plugins/cmakeprojectmanager/cmakeproject.h
View File

@@ -69,7 +69,6 @@ public:
CMakeBuildTarget buildTargetForTitle(const QString &title); CMakeBuildTarget buildTargetForTitle(const QString &title);
bool needsConfiguration() const final; bool needsConfiguration() const final;
bool requiresTargetPanel() const final;
bool knowsAllBuildExecutables() const final; bool knowsAllBuildExecutables() const final;
bool supportsKit(const ProjectExplorer::Kit *k, QString *errorMessage = nullptr) const final; bool supportsKit(const ProjectExplorer::Kit *k, QString *errorMessage = nullptr) const final;

5
src/plugins/projectexplorer/project.cpp
View File

@@ -826,11 +826,6 @@ void Project::configureAsExampleProject(const QSet<Core::Id> &platforms)
Q_UNUSED(platforms); Q_UNUSED(platforms);
} }
bool Project::requiresTargetPanel() const
{
return true;
}
bool Project::needsSpecialDeployment() const bool Project::needsSpecialDeployment() const
{ {
return false; return false;

1
src/plugins/projectexplorer/project.h
View File

@@ -155,7 +155,6 @@ public:
virtual bool needsConfiguration() const; virtual bool needsConfiguration() const;
virtual void configureAsExampleProject(const QSet<Core::Id> &platforms); virtual void configureAsExampleProject(const QSet<Core::Id> &platforms);
virtual bool requiresTargetPanel() const;
virtual ProjectImporter *projectImporter() const; virtual ProjectImporter *projectImporter() const;
Kit::Predicate requiredKitPredicate() const; Kit::Predicate requiredKitPredicate() const;

1
src/plugins/qbsprojectmanager/qbsproject.h
View File

@@ -135,7 +135,6 @@ private:
void projectLoaded() override; void projectLoaded() override;
ProjectExplorer::ProjectImporter *projectImporter() const override; ProjectExplorer::ProjectImporter *projectImporter() const override;
bool needsConfiguration() const override { return targets().isEmpty(); } bool needsConfiguration() const override { return targets().isEmpty(); }
bool requiresTargetPanel() const override { return !targets().isEmpty(); }
static bool ensureWriteableQbsFile(const QString &file); static bool ensureWriteableQbsFile(const QString &file);

5
src/plugins/qmakeprojectmanager/qmakeproject.cpp
View File

@@ -1051,11 +1051,6 @@ void QmakeProject::configureAsExampleProject(const QSet<Core::Id> &platforms)
qDeleteAll(infoList); qDeleteAll(infoList);
} }
bool QmakeProject::requiresTargetPanel() const
{
return !targets().isEmpty();
}
// All the Qmake run configurations should share code. // All the Qmake run configurations should share code.
// This is a rather suboptimal way to do that for disabledReason() // This is a rather suboptimal way to do that for disabledReason()
// but more pratical then duplicated the code everywhere // but more pratical then duplicated the code everywhere

2
src/plugins/qmakeprojectmanager/qmakeproject.h
View File

@@ -109,8 +109,6 @@ public:
void configureAsExampleProject(const QSet<Core::Id> &platforms) final; void configureAsExampleProject(const QSet<Core::Id> &platforms) final;
bool requiresTargetPanel() const final;
/// \internal /// \internal
QString disabledReasonForRunConfiguration(const Utils::FileName &proFilePath); QString disabledReasonForRunConfiguration(const Utils::FileName &proFilePath);