feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix reordering of build steps in the clean list

Browse Source 
* Fix reordering of build steps in the clean list of steps.
 * Make the code more robust and avoid removing and inserting
   the item.
 * Update code for the build steps list too for reasons of symetry.

Reviewed-by: dt
This commit is contained in:
Tobias Hunger
2009-11-30 13:26:27 +01:00
parent fed63463d3
commit 99c9c3c3c0
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/projectexplorer/buildconfiguration.cpp
View File

@@ -143,8 +143,10 @@ void BuildConfiguration::removeBuildStep(int position)
void BuildConfiguration::moveBuildStepUp(int position) void BuildConfiguration::moveBuildStepUp(int position)
{ {
BuildStep *bs = m_buildSteps.takeAt(position); if (position <= 0 || m_buildSteps.size() <= 1)
m_buildSteps.insert(position - 1, bs); return;
m_buildSteps.swap(position - 1, position);
} }
QList<BuildStep *> BuildConfiguration::cleanSteps() const QList<BuildStep *> BuildConfiguration::cleanSteps() const
@@ -165,8 +167,9 @@ void BuildConfiguration::removeCleanStep(int position)
void BuildConfiguration::moveCleanStepUp(int position) void BuildConfiguration::moveCleanStepUp(int position)
{ {
BuildStep *cs = m_cleanSteps.takeAt(position); if (position <= 0 || m_cleanSteps.size() <= 1)
m_cleanSteps.insert(position, cs); return;
m_cleanSteps.swap(position - 1, position);
} }
/// ///