feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

DockFocusController: Avoid using sender() in onFocusedDockAreaViewToggled

Browse Source 
Since m_focusedArea is always a sender of the signal connected to the
onFocusedDockAreaViewToggled() slot, reuse it in place of sender().

Change-Id: I17b817132c8b74e825f0accb9c1d467bfdf24ac3
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This commit is contained in:
Jarek Kobus
2023-10-23 19:56:59 +02:00
parent 611bef47ce
commit 9a8531c22f
1 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/libs/advanceddockingsystem/dockfocuscontroller.cpp
View File

@@ -267,16 +267,9 @@ void DockFocusController::onFocusedDockAreaViewToggled(bool open)
if (d->m_dockManager->isRestoringState() || !d->m_focusedArea || open) if (d->m_dockManager->isRestoringState() || !d->m_focusedArea || open)
return; return;
DockAreaWidget *dockArea = qobject_cast<DockAreaWidget *>(sender()); const auto openedDockAreas = d->m_focusedArea->dockContainer()->openedDockAreas();
if (!dockArea || open) if (!openedDockAreas.isEmpty())
return; d->updateDockWidgetFocus(openedDockAreas.first()->currentDockWidget());
auto container = dockArea->dockContainer();
auto openedDockAreas = container->openedDockAreas();
if (openedDockAreas.isEmpty())
return;
d->updateDockWidgetFocus(openedDockAreas[0]->currentDockWidget());
} }
void DockFocusController::notifyWidgetOrAreaRelocation(QWidget *droppedWidget) void DockFocusController::notifyWidgetOrAreaRelocation(QWidget *droppedWidget)