feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Get rid of DebuggerRunParameters::skipExecutableValidation

Browse Source 
It was only set, but never read.

Task-number: QTCREATORBUG-29168
Change-Id: I441a0c4d2a13a09a938a072b286e1a940ed72ed8
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2025-01-10 13:21:08 +01:00
parent 473af38b14
commit 9b1a85d61b
4 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/android/androiddebugsupport.cpp
View File

@@ -127,7 +127,6 @@ public:
rp.setSolibSearchPath(solibSearchPath); rp.setSolibSearchPath(solibSearchPath);
qCDebug(androidDebugSupportLog).noquote() << "SoLibSearchPath: " << solibSearchPath; qCDebug(androidDebugSupportLog).noquote() << "SoLibSearchPath: " << solibSearchPath;
rp.setSymbolFile(androidAppProcessDir(target).pathAppended("app_process")); rp.setSymbolFile(androidAppProcessDir(target).pathAppended("app_process"));
setSkipExecutableValidation(true);
rp.setUseExtendedRemote(true); rp.setUseExtendedRemote(true);
QString devicePreferredAbi = apkDevicePreferredAbi(target); QString devicePreferredAbi = apkDevicePreferredAbi(target);
setAbi(androidAbi2Abi(devicePreferredAbi)); setAbi(androidAbi2Abi(devicePreferredAbi));

2
src/plugins/debugger/debuggerengine.h
View File

@@ -144,8 +144,6 @@ public:
void setUseCtrlCStub(bool on) { m_useCtrlCStub = on; } void setUseCtrlCStub(bool on) { m_useCtrlCStub = on; }
bool useCtrlCStub() const { return m_useCtrlCStub; } bool useCtrlCStub() const { return m_useCtrlCStub; }
// Used by Android to avoid false positives on warnOnRelease
bool skipExecutableValidation = false;
bool useTargetAsync = false; bool useTargetAsync = false;
Utils::FilePaths additionalSearchDirectories; Utils::FilePaths additionalSearchDirectories;

5
src/plugins/debugger/debuggerruncontrol.cpp
View File

@@ -123,11 +123,6 @@ void DebuggerRunTool::setContinueAfterAttach(bool on)
m_runParameters.continueAfterAttach = on; m_runParameters.continueAfterAttach = on;
} }
void DebuggerRunTool::setSkipExecutableValidation(bool on)
{
m_runParameters.skipExecutableValidation = on;
}
void DebuggerRunTool::setBreakOnMain(bool on) void DebuggerRunTool::setBreakOnMain(bool on)
{ {
m_runParameters.breakOnMain = on; m_runParameters.breakOnMain = on;

1
src/plugins/debugger/debuggerruncontrol.h
View File

@@ -65,7 +65,6 @@ public:
void addSearchDirectory(const Utils::FilePath &dir); void addSearchDirectory(const Utils::FilePath &dir);
void setUseTargetAsync(bool on); void setUseTargetAsync(bool on);
void setSkipExecutableValidation(bool on);
void setIosPlatform(const QString &platform); void setIosPlatform(const QString &platform);
void setDeviceSymbolsRoot(const QString &deviceSymbolsRoot); void setDeviceSymbolsRoot(const QString &deviceSymbolsRoot);