feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Remove AbstractView::emitCustomNotification() overloads

Browse Source 
Use default params instead

Change-Id: I5e8f7bc2bf29e266768fdabb6d000d058499733e
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
This commit is contained in:
Mahmoud Badri
2024-06-10 18:01:14 +03:00
parent 71241c4abb
commit 9b21b643ca
2 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/qmldesigner/designercore/include/abstractview.h
View File

@@ -132,9 +132,8 @@ public:
void emitDocumentMessage(const QList<DocumentMessage> &errors, const QList<DocumentMessage> &warnings = {}); void emitDocumentMessage(const QList<DocumentMessage> &errors, const QList<DocumentMessage> &warnings = {});
void emitDocumentMessage(const QString &error); void emitDocumentMessage(const QString &error);
void emitCustomNotification(const QString &identifier); void emitCustomNotification(const QString &identifier, const QList<ModelNode> &nodeList = {},
void emitCustomNotification(const QString &identifier, const QList<ModelNode> &nodeList); const QList<QVariant> &data = {});
void emitCustomNotification(const QString &identifier, const QList<ModelNode> &nodeList, const QList<QVariant> &data);
void emitInstancePropertyChange(const QList<QPair<ModelNode, PropertyName> > &propertyList); void emitInstancePropertyChange(const QList<QPair<ModelNode, PropertyName> > &propertyList);
void emitInstanceErrorChange(const QVector<qint32> &instanceIds); void emitInstanceErrorChange(const QVector<qint32> &instanceIds);

13
src/plugins/qmldesigner/designercore/model/abstractview.cpp
View File

@@ -669,17 +669,8 @@ void AbstractView::emitDocumentMessage(const QList<DocumentMessage> &errors, con
model()->d->setDocumentMessages(errors, warnings); model()->d->setDocumentMessages(errors, warnings);
} }
void AbstractView::emitCustomNotification(const QString &identifier) void AbstractView::emitCustomNotification(const QString &identifier, const QList<ModelNode> &nodeList,
{ const QList<QVariant> &data)
emitCustomNotification(identifier, QList<ModelNode>());
}
void AbstractView::emitCustomNotification(const QString &identifier, const QList<ModelNode> &nodeList)
{
emitCustomNotification(identifier, nodeList, QList<QVariant>());
}
void AbstractView::emitCustomNotification(const QString &identifier, const QList<ModelNode> &nodeList, const QList<QVariant> &data)
{ {
if (model()) if (model())
model()->d->notifyCustomNotification(this, identifier, nodeList, data); model()->d->notifyCustomNotification(this, identifier, nodeList, data);