feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Optimize condition

Browse Source 
isBasedOn() handles equality.
This already handles equality of types.

Change-Id: If03e083ff6e3446341a37b8fd8fd8978bfc20666
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
This commit is contained in:
Thomas Hartmann
2025-04-10 18:36:34 +02:00
committed by Thomas Hartmann
parent 4d93a8b663
commit 9e995fe801
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/qmldesigner/components/bindingeditor/bindingeditor.cpp
View File

@@ -177,10 +177,8 @@ bool isType(const TypeName &first, const TypeName &second, const Tuple &...types
bool compareTypes(const NodeMetaInfo &sourceType, const NodeMetaInfo &targetType) bool compareTypes(const NodeMetaInfo &sourceType, const NodeMetaInfo &targetType)
{ {
#ifdef QDS_USE_PROJECTSTORAGE #ifdef QDS_USE_PROJECTSTORAGE
return targetType.isVariant() || sourceType.isVariant() || targetType == sourceType return targetType.isVariant() || sourceType.isVariant()
|| (targetType.isNumber() && sourceType.isNumber()) || (targetType.isNumber() && sourceType.isNumber()) || sourceType.isBasedOn(targetType);
|| (targetType.isColor() && sourceType.isColor())
|| (targetType.isString() && sourceType.isString());
#else #else
const TypeName source = sourceType.simplifiedTypeName(); const TypeName source = sourceType.simplifiedTypeName();
const TypeName target = targetType.simplifiedTypeName(); const TypeName target = targetType.simplifiedTypeName();