feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Remove the zombie code regarding CreationDate check

Browse Source 
The CreationDate field was set to hardcoded date of 2012 year
during generation of qch files (from inside qhelpgenerator).
There was no other place in any code which would modify
this field value. So having this field didn't make much sense.
In meantime setting of this field has been removed from
qhelpgenerator, so this field is not being set anymore.
The code which is being removed here, has never been doing anything
which would make much sense, since the compared dates should
always be the same.

Change-Id: I5a628235018223f61f0cbe814e92e1dcd7d34614
Fixes: QTCREATORBUG-20253
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Jarek Kobus
2019-04-18 13:23:26 +02:00
parent a6069aee0b
commit 9f97878c6b
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/help/helpmanager.cpp
View File

@@ -167,18 +167,6 @@ void HelpManager::registerDocumentationNow(QFutureInterface<bool> &futureInterfa
qWarning() << "Error registering namespace '" << nameSpace
<< "' from file '" << file << "':" << helpEngine.error();
}
} else {
const QLatin1String key("CreationDate");
const QString &newDate = helpEngine.metaData(file, key).toString();
const QString &oldDate = helpEngine.metaData(
helpEngine.documentationFileName(nameSpace), key).toString();
if (QDateTime::fromString(newDate, Qt::ISODate)
> QDateTime::fromString(oldDate, Qt::ISODate)) {
if (helpEngine.unregisterDocumentation(nameSpace)) {
docsChanged = true;
helpEngine.registerDocumentation(file);
}
}
}
}
futureInterface.reportResult(docsChanged);