feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Android/iOS: Don't add markup to display names of build steps

Browse Source 
The display name is continuously read and written from/to settings.
Let's not add markup each occurrence, it accumulates.

BuildStep::summaryText has the logic to add the markup for the UI.

Change-Id: Ifbb74ccb8d2f0adcebbd69cc012a5b1376154934
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Alessandro Portale
2021-03-26 07:36:14 +01:00
parent daf19fec84
commit a25ea9febe
2 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/android/androiddeployqtstep.cpp
View File

@@ -494,9 +494,6 @@ QWidget *AndroidDeployQtStep::createConfigWidget()
{ {
auto widget = new QWidget; auto widget = new QWidget;
setDisplayName(QString("<b>%1</b>").arg(displayName()));
setSummaryText(displayName());
auto resetDefaultDevices = new QPushButton(widget); auto resetDefaultDevices = new QPushButton(widget);
resetDefaultDevices->setText(tr("Reset Default Deployment Devices")); resetDefaultDevices->setText(tr("Reset Default Deployment Devices"));

2
src/plugins/ios/iosdeploystep.cpp
View File

@@ -235,8 +235,6 @@ QWidget *IosDeployStep::createConfigWidget()
auto widget = new QWidget; auto widget = new QWidget;
widget->setObjectName("IosDeployStepWidget"); widget->setObjectName("IosDeployStepWidget");
setDisplayName(QString("<b>%1</b>").arg(displayName()));
setSummaryText(displayName());
connect(this, &ProjectConfiguration::displayNameChanged, connect(this, &ProjectConfiguration::displayNameChanged,
this, &BuildStep::updateSummary); this, &BuildStep::updateSummary);