feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify IDevice extra device action setup

Browse Source 
Function objects are easy nowadays.

Change-Id: Iec2b770b99d8f11b7a090fb3bd51af8aa60f6fe0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-01-11 14:50:08 +01:00
parent cc5c899ce0
commit a3c6d30b75
22 changed files with 89 additions and 255 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/plugins/ios/iosdevice.cpp
View File

@@ -130,23 +130,6 @@ IDeviceWidget *IosDevice::createWidget()
return nullptr;
}
QList<Core::Id> IosDevice::actionIds() const
{
return QList<Core::Id>(); // add activation action?
}
QString IosDevice::displayNameForActionId(Core::Id actionId) const
{
Q_UNUSED(actionId)
return QString();
}
void IosDevice::executeAction(Core::Id actionId, QWidget *parent)
{
Q_UNUSED(actionId)
Q_UNUSED(parent)
}
DeviceProcessSignalOperation::Ptr IosDevice::signalOperation() const
{
return DeviceProcessSignalOperation::Ptr();

3
src/plugins/ios/iosdevice.h
View File

@@ -54,9 +54,6 @@ public:
ProjectExplorer::IDevice::DeviceInfo deviceInformation() const override;
ProjectExplorer::IDeviceWidget *createWidget() override;
QList<Core::Id> actionIds() const override;
QString displayNameForActionId(Core::Id actionId) const override;
void executeAction(Core::Id actionId, QWidget *parent = nullptr) override;
ProjectExplorer::DeviceProcessSignalOperation::Ptr signalOperation() const override;
QString displayType() const override;

17
src/plugins/ios/iossimulator.cpp
View File

@@ -89,23 +89,6 @@ IDeviceWidget *IosSimulator::createWidget()
return nullptr;
}
QList<Core::Id> IosSimulator::actionIds() const
{
return QList<Core::Id>();
}
QString IosSimulator::displayNameForActionId(Core::Id actionId) const
{
Q_UNUSED(actionId)
return QString();
}
void IosSimulator::executeAction(Core::Id actionId, QWidget *parent)
{
Q_UNUSED(actionId)
Q_UNUSED(parent)
}
DeviceProcessSignalOperation::Ptr IosSimulator::signalOperation() const
{
return DeviceProcessSignalOperation::Ptr();

3
src/plugins/ios/iossimulator.h
View File

@@ -69,9 +69,6 @@ public:
QString displayType() const override;
ProjectExplorer::IDeviceWidget *createWidget() override;
QList<Core::Id> actionIds() const override;
QString displayNameForActionId(Core::Id actionId) const override;
void executeAction(Core::Id actionId, QWidget *parent = nullptr) override;
ProjectExplorer::DeviceProcessSignalOperation::Ptr signalOperation() const override;
void fromMap(const QVariantMap &map) override;
QVariantMap toMap() const override;