feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix bad use of port numbers.

Browse Source 
-1 is not a valid quint16 number. It gets converted to 65535, which is
a valid port number. So, instead, use port number 0 which isn't valid
(if you try to bind to it, the OS chooses a port for you).

Found by ICC
src/plugins/android/androidrunner.cpp(150): warning #68: integer conversion resulted in a change of sign

Change-Id: I7de033f80b0e4431b7f1ffff13fc4e4f0f7af445
Reviewed-by: BogDan Vatra <bogdan@kde.org>
This commit is contained in:
Thiago Macieira
2015-08-20 16:06:53 -07:00
parent dc8dab3d01
commit a421538414
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/android/androidrunner.cpp
View File

@@ -147,7 +147,7 @@ AndroidRunner::AndroidRunner(QObject *parent,
qDebug() << tr("No free ports available on host for QML debugging.")); qDebug() << tr("No free ports available on host for QML debugging."));
m_qmlPort = server.serverPort(); m_qmlPort = server.serverPort();
} else { } else {
m_qmlPort = -1; m_qmlPort = 0;
} }
ProjectExplorer::Target *target = runConfig->target(); ProjectExplorer::Target *target = runConfig->target();
m_useLocalQtLibs = AndroidManager::useLocalLibs(target); m_useLocalQtLibs = AndroidManager::useLocalLibs(target);