feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Do not emit notifications from Kit::copyFrom()

Browse Source 
This function is a building block for other operations. Emitting a
signal from it will likely provide subscribers with invalid state.

Fixes: QTCREATORBUG-22628
Change-Id: I975638dfa3b453a54c747186b0f6b834c02be035
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Christian Kandeler
2019-06-28 11:08:55 +02:00
parent 3cc286de3d
commit a503c00fd4
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/projectexplorer/kit.cpp
View File

@@ -228,13 +228,11 @@ Kit *Kit::clone(bool keepName) const
void Kit::copyFrom(const Kit *k) void Kit::copyFrom(const Kit *k)
{ {
KitGuard g(this);
copyKitCommon(this, k); copyKitCommon(this, k);
d->m_autodetected = k->d->m_autodetected; d->m_autodetected = k->d->m_autodetected;
d->m_autoDetectionSource = k->d->m_autoDetectionSource; d->m_autoDetectionSource = k->d->m_autoDetectionSource;
d->m_unexpandedDisplayName = k->d->m_unexpandedDisplayName; d->m_unexpandedDisplayName = k->d->m_unexpandedDisplayName;
d->m_fileSystemFriendlyName = k->d->m_fileSystemFriendlyName; d->m_fileSystemFriendlyName = k->d->m_fileSystemFriendlyName;
d->m_mustNotify = true;
} }
bool Kit::isValid() const bool Kit::isValid() const