ProjectExplorer: Remove IDevice::createProcessListModel

All re-implementations are the same nowadays.

Change-Id: I954b3c9ca296967a99ea548ade6282fba188249f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

src/plugins/docker/dockerdevice.cpp

@@ -828,11 +828,6 @@ ProcessInterface *DockerDevice::createProcessInterface() const
     return new DockerProcessImpl(this->sharedFromThis(), d);
 }
 
-ProcessList *DockerDevice::createProcessListModel(QObject *parent) const
-{
-    return new ProcessList(sharedFromThis(), parent);
-}
-
 DeviceTester *DockerDevice::createDeviceTester() const
 {
     return nullptr;

src/plugins/docker/dockerdevice.h

@@ -74,7 +74,6 @@ public:
     Utils::ProcessInterface *createProcessInterface() const override;
 
     bool canCreateProcessModel() const override { return true; }
-    ProjectExplorer::ProcessList *createProcessListModel(QObject *parent) const override;
     bool hasDeviceTester() const override { return false; }
     ProjectExplorer::DeviceTester *createDeviceTester() const override;
     bool usableAsBuildDevice() const override;

src/plugins/projectexplorer/devicesupport/desktopdevice.cpp

@@ -89,11 +89,6 @@ bool DesktopDevice::canCreateProcessModel() const
     return true;
 }
 
-ProcessList *DesktopDevice::createProcessListModel(QObject *parent) const
-{
-    return new ProcessList(sharedFromThis(), parent);
-}
-
 DeviceProcessSignalOperation::Ptr DesktopDevice::signalOperation() const
 {
     return DeviceProcessSignalOperation::Ptr(new DesktopProcessSignalOperation());

src/plugins/projectexplorer/devicesupport/desktopdevice.h

@@ -26,7 +26,6 @@ public:
 
     IDeviceWidget *createWidget() override;
     bool canCreateProcessModel() const override;
-    ProcessList *createProcessListModel(QObject *parent) const override;
     DeviceProcessSignalOperation::Ptr signalOperation() const override;
     QUrl toolControlChannel(const ControlChannelHint &) const override;
     bool usableAsBuildDevice() const override;

src/plugins/projectexplorer/devicesupport/deviceprocessesdialog.cpp

@@ -187,7 +187,8 @@ void DeviceProcessesDialogPrivate::setDevice(const IDevice::ConstPtr &device)
     if (!device)
         return;
 
-    processList.reset(device->createProcessListModel());
+    processList.reset(new ProcessList(device->sharedFromThis(), this));
+
     QTC_ASSERT(processList, return);
     proxyModel.setSourceModel(processList->model());
 

src/plugins/projectexplorer/devicesupport/idevice.cpp

@@ -391,13 +391,6 @@ PortsGatheringMethod IDevice::portsGatheringMethod() const
                 return {filePath("netstat"), {"-a", "-n"}};
             },
             &Port::parseFromCommandOutput};
-};
-
-ProcessList *IDevice::createProcessListModel(QObject *parent) const
-{
-    Q_UNUSED(parent)
-    QTC_ASSERT(false, qDebug("This should not have been called..."); return nullptr);
-    return nullptr;
 }
 
 DeviceTester *IDevice::createDeviceTester() const

src/plugins/projectexplorer/devicesupport/idevice.h

@@ -32,16 +32,14 @@ namespace Utils {
 class CommandLine;
 class DeviceFileAccess;
 class Environment;
-class Icon;
 class PortList;
 class Port;
-class ProcessInterface;
 class Process;
+class ProcessInterface;
 } // Utils
 
 namespace ProjectExplorer {
 
-class ProcessList;
 class FileTransferInterface;
 class FileTransferSetupData;
 class Kit;
@@ -142,7 +140,6 @@ public:
 
     virtual PortsGatheringMethod portsGatheringMethod() const;
     virtual bool canCreateProcessModel() const { return false; }
-    virtual ProcessList *createProcessListModel(QObject *parent = nullptr) const;
     virtual bool hasDeviceTester() const { return false; }
     virtual DeviceTester *createDeviceTester() const;
 

src/plugins/remotelinux/linuxdevice.cpp

@@ -995,11 +995,6 @@ IDeviceWidget *LinuxDevice::createWidget()
     return new Internal::GenericLinuxDeviceConfigurationWidget(sharedFromThis());
 }
 
-ProcessList *LinuxDevice::createProcessListModel(QObject *parent) const
-{
-    return new ProcessList(sharedFromThis(), parent);
-}
-
 DeviceTester *LinuxDevice::createDeviceTester() const
 {
     return new GenericLinuxDeviceTester;

src/plugins/remotelinux/linuxdevice.h

@@ -23,7 +23,6 @@ public:
     ProjectExplorer::IDeviceWidget *createWidget() override;
 
     bool canCreateProcessModel() const override { return true; }
-    ProjectExplorer::ProcessList *createProcessListModel(QObject *parent) const override;
     bool hasDeviceTester() const override { return true; }
     ProjectExplorer::DeviceTester *createDeviceTester() const override;
     ProjectExplorer::DeviceProcessSignalOperation::Ptr signalOperation() const override;